From: Gao feng <gaofeng@cn.fujitsu.com>
To: netfilter-devel <netfilter-devel@vger.kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: nfnetlink_queue: shouldn't it be entry->skb?
Date: Tue, 17 Sep 2013 13:43:48 +0800 [thread overview]
Message-ID: <5237EC14.5010908@cn.fujitsu.com> (raw)
skb is the netlink type sk_buff, shouldn't we pass entry->skb to nfqnl_ct_seq_adjust?
Since I'm blocked by how to send proper netlink message to make nfqnl_ct_parse find
out ct :( , I haven't confirmed this problem. :(
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queu
index 95a98c8..ae2e5c1 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -1009,7 +1009,7 @@ nfqnl_recv_verdict(struct sock *ctnl, struct sk_buff *skb,
verdict = NF_DROP;
if (ct)
- nfqnl_ct_seq_adjust(skb, ct, ctinfo, diff);
+ nfqnl_ct_seq_adjust(entry->skb, ct, ctinfo, diff);
}
next reply other threads:[~2013-09-17 5:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 5:43 Gao feng [this message]
2013-09-17 11:09 ` nfnetlink_queue: shouldn't it be entry->skb? Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5237EC14.5010908@cn.fujitsu.com \
--to=gaofeng@cn.fujitsu.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.