From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VLqIj-00060H-Dt
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 04:06:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VLqId-0007Cd-FW
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 04:06:25 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:54725)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VLqId-0007CW-71
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 04:06:19 -0400
Message-ID: <52380D5F.3000205@huawei.com>
Date: Tue, 17 Sep 2013 10:05:51 +0200
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <1379195690-6509-1-git-send-email-rth@twiddle.net>
	<1379195690-6509-4-git-send-email-rth@twiddle.net>
	<5236B71F.2080807@huawei.com> <52371EC7.60501@twiddle.net>
In-Reply-To: <52371EC7.60501@twiddle.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle
 mov/movi in tcg_out_op
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On 16.09.2013 17:07, Richard Henderson wrote:
> On 09/16/2013 12:45 AM, Claudio Fontana wrote:
>>>>      default:
>>>> -        tcg_abort(); /* opcode not implemented */
>>>> +        /* Opcode not implemented.  */
>>>> +        tcg_abort();
>>>>      }
>>>>  }
>> This change above seems unnecessary.
> 
> Perhaps qemu doesn't have the same "comments are sentences" rule that gcc does,
> but I still aim to follow it.
> 

It is wasteful of y space for no reason. This comment is not a sentence, when you read the code as you would prose.
It is a comment _on_ tcg_abort() : tcg_abort(), because the opcode is not implemented.
In other cases, the comment alone on a line is a good idea, but not in this one.

C.