From: ZhenHua <zhen-hual@hp.com>
To: "Li, Zhen-Hua" <zhen-hual@hp.com>,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Donald Dutile <ddutile@redhat.com>
Subject: Re: [PATCH 1/1] x86/iommu: correct ICS register offset
Date: Tue, 17 Sep 2013 16:38:29 +0800 [thread overview]
Message-ID: <52381505.4010701@hp.com> (raw)
In-Reply-To: <1379053652-29206-1-git-send-email-zhen-hual@hp.com>
Hi Guys,
Though DMAR_ICS_REG is not used yet, I think this patch is
necessary. So please take a look at it.
Thanks
ZhenHua
On 09/13/2013 02:27 PM, Li, Zhen-Hua wrote:
> According to Intel Vt-D specs, the offset of Invalidation complete
> status register should be 0x9C, not 0x98.
>
> See Intel's VT-d spec, Revision 1.3, Chapter 10.4, Page 98;
>
> Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
> ---
> include/linux/intel-iommu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
> index 78e2ada..d380c5e 100644
> --- a/include/linux/intel-iommu.h
> +++ b/include/linux/intel-iommu.h
> @@ -55,7 +55,7 @@
> #define DMAR_IQT_REG 0x88 /* Invalidation queue tail register */
> #define DMAR_IQ_SHIFT 4 /* Invalidation queue head/tail shift */
> #define DMAR_IQA_REG 0x90 /* Invalidation queue addr register */
> -#define DMAR_ICS_REG 0x98 /* Invalidation complete status register */
> +#define DMAR_ICS_REG 0x9c /* Invalidation complete status register */
> #define DMAR_IRTA_REG 0xb8 /* Interrupt remapping table addr register */
>
> #define OFFSET_STRIDE (9)
>
next prev parent reply other threads:[~2013-09-17 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 6:27 [PATCH 1/1] x86/iommu: correct ICS register offset Li, Zhen-Hua
2013-09-13 6:27 ` Li, Zhen-Hua
2013-09-17 8:38 ` ZhenHua [this message]
[not found] ` <52381505.4010701-VXdhtT5mjnY@public.gmane.org>
2013-09-24 11:05 ` Joerg Roedel
2013-09-24 11:05 ` Joerg Roedel
[not found] ` <20130924110551.GC4532-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-09-26 1:35 ` Li, Zhen-Hua
2013-09-26 1:35 ` Li, Zhen-Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52381505.4010701@hp.com \
--to=zhen-hual@hp.com \
--cc=ddutile@redhat.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.