* gstreamer strange distorted image.
@ 2013-09-14 21:56 Dennis Han
2013-09-15 4:52 ` Sandoval Gonzalez Leonardo-B42214
[not found] ` <000a01ceb1d2$4d58d940$e80a8bc0$@freescale.com>
0 siblings, 2 replies; 17+ messages in thread
From: Dennis Han @ 2013-09-14 21:56 UTC (permalink / raw)
To: meta-freescale
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
Hi.
Would anybody test following video clip ?
I got very strange result from it.
http://mcluster.com/new4-cut.mp4
Playing in fullscreen, Images are distorted. While showing resized seems
fine.
I got same result in qt4 phonon base player, qmediaplayer.
Env: qt-in-use-image in master branch.
Regards.
[-- Attachment #2: Type: text/html, Size: 2899 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: gstreamer strange distorted image. 2013-09-14 21:56 gstreamer strange distorted image Dennis Han @ 2013-09-15 4:52 ` Sandoval Gonzalez Leonardo-B42214 2013-09-15 23:55 ` Otavio Salvador [not found] ` <000a01ceb1d2$4d58d940$e80a8bc0$@freescale.com> 1 sibling, 1 reply; 17+ messages in thread From: Sandoval Gonzalez Leonardo-B42214 @ 2013-09-15 4:52 UTC (permalink / raw) To: Dennis Han, meta-freescale@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 776 bytes --] Are you displaying it on HDMI? is it a high resolution video? If both yes, it is a known issue and there is a fix for it on the community. Leo ________________________________ From: meta-freescale-bounces@yoctoproject.org [meta-freescale-bounces@yoctoproject.org] on behalf of Dennis Han [jshan@live.co.kr] Sent: Saturday, September 14, 2013 4:56 PM To: meta-freescale@yoctoproject.org Subject: [meta-freescale] gstreamer strange distorted image. Hi. Would anybody test following video clip ? I got very strange result from it. http://mcluster.com/new4-cut.mp4 Playing in fullscreen, Images are distorted. While showing resized seems fine. I got same result in qt4 phonon base player, qmediaplayer. Env: qt-in-use-image in master branch. Regards. [-- Attachment #2: Type: text/html, Size: 2916 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-15 4:52 ` Sandoval Gonzalez Leonardo-B42214 @ 2013-09-15 23:55 ` Otavio Salvador 2013-09-16 4:19 ` Sandoval Gonzalez Leonardo-B42214 ` (2 more replies) 0 siblings, 3 replies; 17+ messages in thread From: Otavio Salvador @ 2013-09-15 23:55 UTC (permalink / raw) To: Sandoval Gonzalez Leonardo-B42214; +Cc: meta-freescale@yoctoproject.org Hello Leonardo, On Sun, Sep 15, 2013 at 1:52 AM, Sandoval Gonzalez Leonardo-B42214 <B42214@freescale.com> wrote: > Are you displaying it on HDMI? is it a high resolution video? If both yes, > it is a known issue and there is a fix for it on the community. Please send a patch so we avoid this problem for other users; Dennis, please report a bug in bugzilla so this is not forgotten. Regards, -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-15 23:55 ` Otavio Salvador @ 2013-09-16 4:19 ` Sandoval Gonzalez Leonardo-B42214 [not found] ` <000401ceb2a4$5d8a2bc0$189e8340$@freescale.com> 2013-09-16 14:13 ` Eric Nelson 2 siblings, 0 replies; 17+ messages in thread From: Sandoval Gonzalez Leonardo-B42214 @ 2013-09-16 4:19 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org Sure Otavio, I will send the correct patch soon. Dennis, in the meantime, can you try the one below: From 6ae2813aed1063143400de8fe111a9d9a6130a4a Mon Sep 17 00:00:00 2001 From: Oliver Brown <b37094@b37094-vmlinux.(none)> Date: Wed, 24 Jul 2013 00:20:26 -0500 Subject: [PATCH] ENGR00272541 [IPU] - IC_RSZ_MAX_RESIZE_RATIO should be set to 0x2000 The max resize ratio should be set to 0x2000 (or 8192). Signed-off-by: Oliver Brown <b37094@b37094-vmlinux.(none)> --- drivers/mxc/ipu3/ipu_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 drivers/mxc/ipu3/ipu_regs.h diff --git a/drivers/mxc/ipu3/ipu_regs.h b/drivers/mxc/ipu3/ipu_regs.h old mode 100644 new mode 100755 index 94c587e..f089f7d --- a/drivers/mxc/ipu3/ipu_regs.h +++ b/drivers/mxc/ipu3/ipu_regs.h @@ -465,7 +465,7 @@ enum { IC_CONF_RWS_EN = 0x40000000, IC_CONF_CSI_MEM_WR_EN = 0x80000000, - IC_RSZ_MAX_RESIZE_RATIO = 0x00004000, + IC_RSZ_MAX_RESIZE_RATIO = 0x00002000, IC_IDMAC_1_CB0_BURST_16 = 0x00000001, IC_IDMAC_1_CB1_BURST_16 = 0x00000002, -- 1.7.9.5 ________________________________________ From: otavio.salvador@gmail.com [otavio.salvador@gmail.com] on behalf of Otavio Salvador [otavio@ossystems.com.br] Sent: Sunday, September 15, 2013 6:55 PM To: Sandoval Gonzalez Leonardo-B42214 Cc: Dennis Han; meta-freescale@yoctoproject.org Subject: Re: [meta-freescale] gstreamer strange distorted image. Hello Leonardo, On Sun, Sep 15, 2013 at 1:52 AM, Sandoval Gonzalez Leonardo-B42214 <B42214@freescale.com> wrote: > Are you displaying it on HDMI? is it a high resolution video? If both yes, > it is a known issue and there is a fix for it on the community. Please send a patch so we avoid this problem for other users; Dennis, please report a bug in bugzilla so this is not forgotten. Regards, -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply related [flat|nested] 17+ messages in thread
[parent not found: <000401ceb2a4$5d8a2bc0$189e8340$@freescale.com>]
* Re: gstreamer strange distorted image. [not found] ` <000401ceb2a4$5d8a2bc0$189e8340$@freescale.com> @ 2013-09-16 8:49 ` Dennis Han 2013-09-16 11:07 ` Otavio Salvador [not found] ` <000101ceb2cd$cfea6d50$6fbf47f0$@ossystems.com.br> 2013-09-16 20:34 ` Dennis Han 1 sibling, 2 replies; 17+ messages in thread From: Dennis Han @ 2013-09-16 8:49 UTC (permalink / raw) To: 'Sandoval Gonzalez Leonardo-B42214', 'Otavio Salvador' Cc: meta-freescale Hi Leonardo. The patch doesn't work at all. But, I think it relates to ipu fb (mxc_ipuv3_fb). Still testing on fb, especially, fb_pix_fmt. And, I found another thing. It's not related my issue though, In mxc_ipuv3_fb.c Line 1322, case MXCFB_CSC_UPDATE statement. There is no "break" Is it intended ? Salvador I did update the report. Bug 5202 Bugzilla. -----Original Message----- From: Sandoval Gonzalez Leonardo-B42214 [mailto:B42214@freescale.com] Sent: Monday, September 16, 2013 1:20 PM To: Otavio Salvador Cc: Dennis Han; meta-freescale@yoctoproject.org Subject: RE: [meta-freescale] gstreamer strange distorted image. Sure Otavio, I will send the correct patch soon. Dennis, in the meantime, can you try the one below: From 6ae2813aed1063143400de8fe111a9d9a6130a4a Mon Sep 17 00:00:00 2001 From: Oliver Brown <b37094@b37094-vmlinux.(none)> Date: Wed, 24 Jul 2013 00:20:26 -0500 Subject: [PATCH] ENGR00272541 [IPU] - IC_RSZ_MAX_RESIZE_RATIO should be set to 0x2000 The max resize ratio should be set to 0x2000 (or 8192). Signed-off-by: Oliver Brown <b37094@b37094-vmlinux.(none)> --- drivers/mxc/ipu3/ipu_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 drivers/mxc/ipu3/ipu_regs.h diff --git a/drivers/mxc/ipu3/ipu_regs.h b/drivers/mxc/ipu3/ipu_regs.h old mode 100644 new mode 100755 index 94c587e..f089f7d --- a/drivers/mxc/ipu3/ipu_regs.h +++ b/drivers/mxc/ipu3/ipu_regs.h @@ -465,7 +465,7 @@ enum { IC_CONF_RWS_EN = 0x40000000, IC_CONF_CSI_MEM_WR_EN = 0x80000000, - IC_RSZ_MAX_RESIZE_RATIO = 0x00004000, + IC_RSZ_MAX_RESIZE_RATIO = 0x00002000, IC_IDMAC_1_CB0_BURST_16 = 0x00000001, IC_IDMAC_1_CB1_BURST_16 = 0x00000002, -- 1.7.9.5 ________________________________________ From: otavio.salvador@gmail.com [otavio.salvador@gmail.com] on behalf of Otavio Salvador [otavio@ossystems.com.br] Sent: Sunday, September 15, 2013 6:55 PM To: Sandoval Gonzalez Leonardo-B42214 Cc: Dennis Han; meta-freescale@yoctoproject.org Subject: Re: [meta-freescale] gstreamer strange distorted image. Hello Leonardo, On Sun, Sep 15, 2013 at 1:52 AM, Sandoval Gonzalez Leonardo-B42214 <B42214@freescale.com> wrote: > Are you displaying it on HDMI? is it a high resolution video? If both yes, > it is a known issue and there is a fix for it on the community. Please send a patch so we avoid this problem for other users; Dennis, please report a bug in bugzilla so this is not forgotten. Regards, -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-16 8:49 ` Dennis Han @ 2013-09-16 11:07 ` Otavio Salvador [not found] ` <000101ceb2cd$cfea6d50$6fbf47f0$@ossystems.com.br> 1 sibling, 0 replies; 17+ messages in thread From: Otavio Salvador @ 2013-09-16 11:07 UTC (permalink / raw) To: Dennis Han Cc: Sandoval Gonzalez Leonardo-B42214, meta-freescale@yoctoproject.org On Mon, Sep 16, 2013 at 5:49 AM, Dennis Han <jshan@live.co.kr> wrote: > Hi Leonardo. > The patch doesn't work at all. > But, I think it relates to ipu fb (mxc_ipuv3_fb). > > Still testing on fb, especially, fb_pix_fmt. > > And, > > I found another thing. > It's not related my issue though, > > In mxc_ipuv3_fb.c > Line 1322, > case MXCFB_CSC_UPDATE statement. > There is no "break" > > Is it intended ? > > > Salvador > I did update the report. > Bug 5202 Bugzilla. Good; so let's use it to track the progress for it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <000101ceb2cd$cfea6d50$6fbf47f0$@ossystems.com.br>]
* Re: gstreamer strange distorted image. [not found] ` <000101ceb2cd$cfea6d50$6fbf47f0$@ossystems.com.br> @ 2013-09-16 14:05 ` Dennis Han 0 siblings, 0 replies; 17+ messages in thread From: Dennis Han @ 2013-09-16 14:05 UTC (permalink / raw) To: 'Otavio Salvador' Cc: 'Sandoval Gonzalez Leonardo-B42214', meta-freescale Well, I just solved (?) my issue. But, I don't think it would be the correct fix. Anyway, I want to explain the reason for distorted images. There is mxc_fbi->fb_pix_fmt value in mxc_ipuv3_fb.c taking from u-boot parameter. So, default would be IPU_PIX_FMT_RGB24 like mine. (if set HDMI). Almost every video clips I have tested ok and not distorted. In kernel ipu fb driver, It doesn't change the format while v4l update (crop, panning resize) Yes, this time, ipu fb stream is IPU_PIX_FMT_RGB24 format. But the video clip that I attached before not like those. And it suddenly changed to NV12 format while v4l update. I don't know why. Somebody explain to me. So, I changed to the code to recheck the pixel format when _setup_disp_channel1 and set it to mxc_fbi->fb_pix_fmt. After that the video clip is normally displaying and no more distorted. Any comment would be appreciated. -----Original Message----- From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf Of Otavio Salvador Sent: Monday, September 16, 2013 8:08 PM To: Dennis Han Cc: Sandoval Gonzalez Leonardo-B42214; meta-freescale@yoctoproject.org Subject: Re: [meta-freescale] gstreamer strange distorted image. On Mon, Sep 16, 2013 at 5:49 AM, Dennis Han <jshan@live.co.kr> wrote: > Hi Leonardo. > The patch doesn't work at all. > But, I think it relates to ipu fb (mxc_ipuv3_fb). > > Still testing on fb, especially, fb_pix_fmt. > > And, > > I found another thing. > It's not related my issue though, > > In mxc_ipuv3_fb.c > Line 1322, > case MXCFB_CSC_UPDATE statement. > There is no "break" > > Is it intended ? > > > Salvador > I did update the report. > Bug 5202 Bugzilla. Good; so let's use it to track the progress for it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. [not found] ` <000401ceb2a4$5d8a2bc0$189e8340$@freescale.com> 2013-09-16 8:49 ` Dennis Han @ 2013-09-16 20:34 ` Dennis Han 2013-09-16 21:19 ` Otavio Salvador 1 sibling, 1 reply; 17+ messages in thread From: Dennis Han @ 2013-09-16 20:34 UTC (permalink / raw) To: 'Sandoval Gonzalez Leonardo-B42214', 'Otavio Salvador' Cc: meta-freescale I tested you patch more detail and found a problem. In brief. 1. With original value IC_RSZ_MAX_RESIZE_RATIO = 0x00004000 >> it's OK 2. With a new value IC_RSZ_MAX_RESIZE_RATIO = 0x00002000 >> center pixels are overlapping I think this patch has to be ignored. -----Original Message----- From: Sandoval Gonzalez Leonardo-B42214 [mailto:B42214@freescale.com] Sent: Monday, September 16, 2013 1:20 PM To: Otavio Salvador Cc: Dennis Han; meta-freescale@yoctoproject.org Subject: RE: [meta-freescale] gstreamer strange distorted image. Sure Otavio, I will send the correct patch soon. Dennis, in the meantime, can you try the one below: From 6ae2813aed1063143400de8fe111a9d9a6130a4a Mon Sep 17 00:00:00 2001 From: Oliver Brown <b37094@b37094-vmlinux.(none)> Date: Wed, 24 Jul 2013 00:20:26 -0500 Subject: [PATCH] ENGR00272541 [IPU] - IC_RSZ_MAX_RESIZE_RATIO should be set to 0x2000 The max resize ratio should be set to 0x2000 (or 8192). Signed-off-by: Oliver Brown <b37094@b37094-vmlinux.(none)> --- drivers/mxc/ipu3/ipu_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 drivers/mxc/ipu3/ipu_regs.h diff --git a/drivers/mxc/ipu3/ipu_regs.h b/drivers/mxc/ipu3/ipu_regs.h old mode 100644 new mode 100755 index 94c587e..f089f7d --- a/drivers/mxc/ipu3/ipu_regs.h +++ b/drivers/mxc/ipu3/ipu_regs.h @@ -465,7 +465,7 @@ enum { IC_CONF_RWS_EN = 0x40000000, IC_CONF_CSI_MEM_WR_EN = 0x80000000, - IC_RSZ_MAX_RESIZE_RATIO = 0x00004000, + IC_RSZ_MAX_RESIZE_RATIO = 0x00002000, IC_IDMAC_1_CB0_BURST_16 = 0x00000001, IC_IDMAC_1_CB1_BURST_16 = 0x00000002, -- 1.7.9.5 ________________________________________ From: otavio.salvador@gmail.com [otavio.salvador@gmail.com] on behalf of Otavio Salvador [otavio@ossystems.com.br] Sent: Sunday, September 15, 2013 6:55 PM To: Sandoval Gonzalez Leonardo-B42214 Cc: Dennis Han; meta-freescale@yoctoproject.org Subject: Re: [meta-freescale] gstreamer strange distorted image. Hello Leonardo, On Sun, Sep 15, 2013 at 1:52 AM, Sandoval Gonzalez Leonardo-B42214 <B42214@freescale.com> wrote: > Are you displaying it on HDMI? is it a high resolution video? If both yes, > it is a known issue and there is a fix for it on the community. Please send a patch so we avoid this problem for other users; Dennis, please report a bug in bugzilla so this is not forgotten. Regards, -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-16 20:34 ` Dennis Han @ 2013-09-16 21:19 ` Otavio Salvador 2013-09-17 0:23 ` Eric Nelson 0 siblings, 1 reply; 17+ messages in thread From: Otavio Salvador @ 2013-09-16 21:19 UTC (permalink / raw) To: Dennis Han Cc: Sandoval Gonzalez Leonardo-B42214, meta-freescale@yoctoproject.org On Mon, Sep 16, 2013 at 5:34 PM, Dennis Han <jshan@live.co.kr> wrote: > I tested you patch more detail and found a problem. > > In brief. > > 1. With original value > IC_RSZ_MAX_RESIZE_RATIO = 0x00004000 >>> it's OK > > > 2. With a new value > IC_RSZ_MAX_RESIZE_RATIO = 0x00002000 >>> center pixels are overlapping > > > I think this patch has to be ignored. Good for testing and letting us know about the result. Eric, does it also fails for you? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-16 21:19 ` Otavio Salvador @ 2013-09-17 0:23 ` Eric Nelson 2013-09-17 0:37 ` Eric Nelson [not found] ` <000301ceb34d$5c62b6f0$152824d0$@boundarydevices.com> 0 siblings, 2 replies; 17+ messages in thread From: Eric Nelson @ 2013-09-17 0:23 UTC (permalink / raw) To: Otavio Salvador Cc: Sandoval Gonzalez Leonardo-B42214, meta-freescale@yoctoproject.org On 09/16/2013 02:19 PM, Otavio Salvador wrote: > On Mon, Sep 16, 2013 at 5:34 PM, Dennis Han <jshan@live.co.kr> wrote: >> I tested you patch more detail and found a problem. >> >> In brief. >> >> 1. With original value >> IC_RSZ_MAX_RESIZE_RATIO = 0x00004000 >>>> it's OK >> >> >> 2. With a new value >> IC_RSZ_MAX_RESIZE_RATIO = 0x00002000 >>>> center pixels are overlapping >> >> >> I think this patch has to be ignored. > > Good for testing and letting us know about the result. Eric, does it > also fails for you? > The re-sizing patch did nothing for me, while our patch fixed the issue playing the file in both qtmediaplayer and gst-launch/playbin2. I'm not testing with qt-in-use-image, but another qt4e image with a patched-up 4.0.0 kernel. This makes sense because the video is 1280x720 and the display is also 1280x720. Dennis, is this your screen resolution? Please advise, Eric ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-17 0:23 ` Eric Nelson @ 2013-09-17 0:37 ` Eric Nelson 2013-09-17 1:47 ` Otavio Salvador [not found] ` <000301ceb34d$5c62b6f0$152824d0$@boundarydevices.com> 1 sibling, 1 reply; 17+ messages in thread From: Eric Nelson @ 2013-09-17 0:37 UTC (permalink / raw) To: Otavio Salvador, Sandoval Gonzalez Leonardo-B42214 Cc: meta-freescale@yoctoproject.org On 09/16/2013 05:23 PM, Eric Nelson wrote: > On 09/16/2013 02:19 PM, Otavio Salvador wrote: >> On Mon, Sep 16, 2013 at 5:34 PM, Dennis Han <jshan@live.co.kr> wrote: >>> I tested you patch more detail and found a problem. >>> >>> In brief. >>> >>> 1. With original value >>> IC_RSZ_MAX_RESIZE_RATIO = 0x00004000 >>>>> it's OK >>> >>> >>> 2. With a new value >>> IC_RSZ_MAX_RESIZE_RATIO = 0x00002000 >>>>> center pixels are overlapping >>> >>> >>> I think this patch has to be ignored. >> >> Good for testing and letting us know about the result. Eric, does it >> also fails for you? >> > > The re-sizing patch did nothing for me, while our patch > fixed the issue playing the file in both qtmediaplayer > and gst-launch/playbin2. > > I'm not testing with qt-in-use-image, but another qt4e > image with a patched-up 4.0.0 kernel. > > This makes sense because the video is 1280x720 and the > display is also 1280x720. > I meant to add some details about what we're seeing. It's very clear when playing full-screen that the issue is one of a missing color-space conversion. Playing Dennis' video clearly shows that the data is in NV12 (YUV planar) format, with two instances of the video across the top of the screen, followed by a very distorted bottom 1/3 or so. Our patch circumvents code elsewhere in the V4L2 driver that appears to be an optimization for the case where the YUV plane can be output directly and the display can somehow do the conversion. https://github.com/boundarydevices/linux-imx6/commit/c4eb189e1cae98c5535c0a26e859a010b0c70510 Also interesting is that when qmediaplayer starts up, it seems to tell V4L2 to start up a 1280x720 plane, but not at offset 0,0. In other words, it's not full-screen, so the "bypass CSC" logic seems to be missing another component in determining whether the YUV plane is "full screen". Oh, and the Qt4 Phonon layer should probably be patched to shrink the overlay size if the initial window position doesn't allow the overlay to fit on the screen. Regards, Eric ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-17 0:37 ` Eric Nelson @ 2013-09-17 1:47 ` Otavio Salvador 2013-09-17 13:31 ` Eric Nelson 0 siblings, 1 reply; 17+ messages in thread From: Otavio Salvador @ 2013-09-17 1:47 UTC (permalink / raw) To: Eric Nelson Cc: Sandoval Gonzalez Leonardo-B42214, meta-freescale@yoctoproject.org On Mon, Sep 16, 2013 at 9:37 PM, Eric Nelson <eric.nelson@boundarydevices.com> wrote: > On 09/16/2013 05:23 PM, Eric Nelson wrote: >> >> On 09/16/2013 02:19 PM, Otavio Salvador wrote: >>> >>> On Mon, Sep 16, 2013 at 5:34 PM, Dennis Han <jshan@live.co.kr> wrote: >>>> >>>> I tested you patch more detail and found a problem. >>>> >>>> In brief. >>>> >>>> 1. With original value >>>> IC_RSZ_MAX_RESIZE_RATIO = 0x00004000 >>>>>> >>>>>> it's OK >>>> >>>> >>>> >>>> 2. With a new value >>>> IC_RSZ_MAX_RESIZE_RATIO = 0x00002000 >>>>>> >>>>>> center pixels are overlapping >>>> >>>> >>>> >>>> I think this patch has to be ignored. >>> >>> >>> Good for testing and letting us know about the result. Eric, does it >>> also fails for you? >>> >> >> The re-sizing patch did nothing for me, while our patch >> fixed the issue playing the file in both qtmediaplayer >> and gst-launch/playbin2. >> >> I'm not testing with qt-in-use-image, but another qt4e >> image with a patched-up 4.0.0 kernel. >> >> This makes sense because the video is 1280x720 and the >> display is also 1280x720. >> > > I meant to add some details about what we're seeing. > > It's very clear when playing full-screen that the > issue is one of a missing color-space conversion. > > Playing Dennis' video clearly shows that the data > is in NV12 (YUV planar) format, with two instances > of the video across the top of the screen, followed > by a very distorted bottom 1/3 or so. > > Our patch circumvents code elsewhere in the V4L2 > driver that appears to be an optimization for the > case where the YUV plane can be output directly and > the display can somehow do the conversion. > > > https://github.com/boundarydevices/linux-imx6/commit/c4eb189e1cae98c5535c0a26e859a010b0c70510 Shouldn't 'g_fb_setting[i].disp_support_csc' be fixed to properly return 0? > Also interesting is that when qmediaplayer starts up, > it seems to tell V4L2 to start up a 1280x720 plane, > but not at offset 0,0. In other words, it's not full-screen, > so the "bypass CSC" logic seems to be missing another > component in determining whether the YUV plane is "full screen". > > Oh, and the Qt4 Phonon layer should probably be patched > to shrink the overlay size if the initial window position > doesn't allow the overlay to fit on the screen. Patches?! This is 'encrypted' for me so I have no way to help on this ;-) -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-17 1:47 ` Otavio Salvador @ 2013-09-17 13:31 ` Eric Nelson 0 siblings, 0 replies; 17+ messages in thread From: Eric Nelson @ 2013-09-17 13:31 UTC (permalink / raw) To: Otavio Salvador Cc: Sandoval Gonzalez Leonardo-B42214, meta-freescale@yoctoproject.org On 09/16/2013 06:47 PM, Otavio Salvador wrote: > On Mon, Sep 16, 2013 at 9:37 PM, Eric Nelson > <eric.nelson@boundarydevices.com> wrote: >> On 09/16/2013 05:23 PM, Eric Nelson wrote: >>> >>> On 09/16/2013 02:19 PM, Otavio Salvador wrote: >>>> >>>> On Mon, Sep 16, 2013 at 5:34 PM, Dennis Han <jshan@live.co.kr> wrote: >>>> >> Our patch circumvents code elsewhere in the V4L2 >> driver that appears to be an optimization for the >> case where the YUV plane can be output directly and >> the display can somehow do the conversion. >> >> https://github.com/boundarydevices/linux-imx6/commit/c4eb189e1cae98c5535c0a26e859a010b0c70510 > > Shouldn't 'g_fb_setting[i].disp_support_csc' be fixed to properly return 0? > It seems that I got tired or hungry when walking this backward from the decision to skip color-space conversion ;) Thanks for pointing this out. ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <000301ceb34d$5c62b6f0$152824d0$@boundarydevices.com>]
* Re: gstreamer strange distorted image. [not found] ` <000301ceb34d$5c62b6f0$152824d0$@boundarydevices.com> @ 2013-09-17 5:17 ` Dennis Han 0 siblings, 0 replies; 17+ messages in thread From: Dennis Han @ 2013-09-17 5:17 UTC (permalink / raw) To: 'Eric Nelson', 'Otavio Salvador', 'Sandoval Gonzalez Leonardo-B42214' Cc: meta-freescale Hi Eric. It makes sense. And your patch work well too. I'll take your patch. -----Original Message----- From: Eric Nelson [mailto:eric.nelson@boundarydevices.com] Sent: Tuesday, September 17, 2013 9:37 AM To: Otavio Salvador; Sandoval Gonzalez Leonardo-B42214 Cc: Dennis Han; meta-freescale@yoctoproject.org Subject: Re: [meta-freescale] gstreamer strange distorted image. On 09/16/2013 05:23 PM, Eric Nelson wrote: > On 09/16/2013 02:19 PM, Otavio Salvador wrote: >> On Mon, Sep 16, 2013 at 5:34 PM, Dennis Han <jshan@live.co.kr> wrote: >>> I tested you patch more detail and found a problem. >>> >>> In brief. >>> >>> 1. With original value >>> IC_RSZ_MAX_RESIZE_RATIO = 0x00004000 >>>>> it's OK >>> >>> >>> 2. With a new value >>> IC_RSZ_MAX_RESIZE_RATIO = 0x00002000 >>>>> center pixels are overlapping >>> >>> >>> I think this patch has to be ignored. >> >> Good for testing and letting us know about the result. Eric, does it >> also fails for you? >> > > The re-sizing patch did nothing for me, while our patch fixed the > issue playing the file in both qtmediaplayer and gst-launch/playbin2. > > I'm not testing with qt-in-use-image, but another qt4e image with a > patched-up 4.0.0 kernel. > > This makes sense because the video is 1280x720 and the display is also > 1280x720. > I meant to add some details about what we're seeing. It's very clear when playing full-screen that the issue is one of a missing color-space conversion. Playing Dennis' video clearly shows that the data is in NV12 (YUV planar) format, with two instances of the video across the top of the screen, followed by a very distorted bottom 1/3 or so. Our patch circumvents code elsewhere in the V4L2 driver that appears to be an optimization for the case where the YUV plane can be output directly and the display can somehow do the conversion. https://github.com/boundarydevices/linux-imx6/commit/c4eb189e1cae98c5535c0a26e859a010b0c70510 Also interesting is that when qmediaplayer starts up, it seems to tell V4L2 to start up a 1280x720 plane, but not at offset 0,0. In other words, it's not full-screen, so the "bypass CSC" logic seems to be missing another component in determining whether the YUV plane is "full screen". Oh, and the Qt4 Phonon layer should probably be patched to shrink the overlay size if the initial window position doesn't allow the overlay to fit on the screen. Regards, Eric ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-15 23:55 ` Otavio Salvador 2013-09-16 4:19 ` Sandoval Gonzalez Leonardo-B42214 [not found] ` <000401ceb2a4$5d8a2bc0$189e8340$@freescale.com> @ 2013-09-16 14:13 ` Eric Nelson 2013-09-16 16:25 ` Otavio Salvador 2 siblings, 1 reply; 17+ messages in thread From: Eric Nelson @ 2013-09-16 14:13 UTC (permalink / raw) To: Otavio Salvador Cc: Sandoval Gonzalez Leonardo-B42214, meta-freescale@yoctoproject.org On 09/15/2013 04:55 PM, Otavio Salvador wrote: > Hello Leonardo, > > On Sun, Sep 15, 2013 at 1:52 AM, Sandoval Gonzalez Leonardo-B42214 > <B42214@freescale.com> wrote: >> Are you displaying it on HDMI? is it a high resolution video? If both yes, >> it is a known issue and there is a fix for it on the community. > > Please send a patch so we avoid this problem for other users; Dennis, > please report a bug in bugzilla so this is not forgotten. > Hi Otavio, I also didn't find a fix on i.MX Community, but we narrowed down the problem and pushed a fix to our non-Android kernels (Android doesn't use V4Lsink): https://github.com/boundarydevices/linux-imx6/commit/c4eb189e1cae98c5535c0a26e859a010b0c70510 We found that the driver was somehow deciding that the display could perform a color-space conversion. I'm not certain what types of displays can do this, but none of ours do (including TV encoder with NTSC/PAL output). Regards, Eric ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: gstreamer strange distorted image. 2013-09-16 14:13 ` Eric Nelson @ 2013-09-16 16:25 ` Otavio Salvador 0 siblings, 0 replies; 17+ messages in thread From: Otavio Salvador @ 2013-09-16 16:25 UTC (permalink / raw) To: Eric Nelson, Lauren Post, Mahesh Mahadevan Cc: Sandoval Gonzalez Leonardo-B42214, meta-freescale@yoctoproject.org On Mon, Sep 16, 2013 at 11:13 AM, Eric Nelson <eric.nelson@boundarydevices.com> wrote: > On 09/15/2013 04:55 PM, Otavio Salvador wrote: >> >> Hello Leonardo, >> >> On Sun, Sep 15, 2013 at 1:52 AM, Sandoval Gonzalez Leonardo-B42214 >> <B42214@freescale.com> wrote: >>> >>> Are you displaying it on HDMI? is it a high resolution video? If both >>> yes, >>> it is a known issue and there is a fix for it on the community. >> >> >> Please send a patch so we avoid this problem for other users; Dennis, >> please report a bug in bugzilla so this is not forgotten. >> > Hi Otavio, > > I also didn't find a fix on i.MX Community, but we narrowed down > the problem and pushed a fix to our non-Android kernels (Android > doesn't use V4Lsink): > > > https://github.com/boundarydevices/linux-imx6/commit/c4eb189e1cae98c5535c0a26e859a010b0c70510 > > We found that the driver was somehow deciding that the > display could perform a color-space conversion. I'm not > certain what types of displays can do this, but none of > ours do (including TV encoder with NTSC/PAL output). (adding Lauren and Mahesh to Cc) Could this be reviewed for inclusion in 4.1.0 tree? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <000a01ceb1d2$4d58d940$e80a8bc0$@freescale.com>]
* Re: gstreamer strange distorted image. [not found] ` <000a01ceb1d2$4d58d940$e80a8bc0$@freescale.com> @ 2013-09-15 5:40 ` Dennis Han 0 siblings, 0 replies; 17+ messages in thread From: Dennis Han @ 2013-09-15 5:40 UTC (permalink / raw) To: 'Sandoval Gonzalez Leonardo-B42214', meta-freescale [-- Attachment #1: Type: text/plain, Size: 1247 bytes --] Thanks. Yes, it's HDMI 720p output and 1280x720 resolution media file. (h264) commumity ? you mean freescale community ? I looked up the community but I got nothing. Plz, leave me a link. From: Sandoval Gonzalez Leonardo-B42214 [mailto:B42214@freescale.com] Sent: Sunday, September 15, 2013 1:52 PM To: Dennis Han; meta-freescale@yoctoproject.org Subject: RE: [meta-freescale] gstreamer strange distorted image. Are you displaying it on HDMI? is it a high resolution video? If both yes, it is a known issue and there is a fix for it on the community. Leo _____ From: meta-freescale-bounces@yoctoproject.org [meta-freescale-bounces@yoctoproject.org] on behalf of Dennis Han [jshan@live.co.kr] Sent: Saturday, September 14, 2013 4:56 PM To: meta-freescale@yoctoproject.org Subject: [meta-freescale] gstreamer strange distorted image. Hi. Would anybody test following video clip ? I got very strange result from it. http://mcluster.com/new4-cut.mp4 Playing in fullscreen, Images are distorted. While showing resized seems fine. I got same result in qt4 phonon base player, qmediaplayer. Env: qt-in-use-image in master branch. Regards. [-- Attachment #2: Type: text/html, Size: 7758 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2013-09-17 13:31 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-14 21:56 gstreamer strange distorted image Dennis Han
2013-09-15 4:52 ` Sandoval Gonzalez Leonardo-B42214
2013-09-15 23:55 ` Otavio Salvador
2013-09-16 4:19 ` Sandoval Gonzalez Leonardo-B42214
[not found] ` <000401ceb2a4$5d8a2bc0$189e8340$@freescale.com>
2013-09-16 8:49 ` Dennis Han
2013-09-16 11:07 ` Otavio Salvador
[not found] ` <000101ceb2cd$cfea6d50$6fbf47f0$@ossystems.com.br>
2013-09-16 14:05 ` Dennis Han
2013-09-16 20:34 ` Dennis Han
2013-09-16 21:19 ` Otavio Salvador
2013-09-17 0:23 ` Eric Nelson
2013-09-17 0:37 ` Eric Nelson
2013-09-17 1:47 ` Otavio Salvador
2013-09-17 13:31 ` Eric Nelson
[not found] ` <000301ceb34d$5c62b6f0$152824d0$@boundarydevices.com>
2013-09-17 5:17 ` Dennis Han
2013-09-16 14:13 ` Eric Nelson
2013-09-16 16:25 ` Otavio Salvador
[not found] ` <000a01ceb1d2$4d58d940$e80a8bc0$@freescale.com>
2013-09-15 5:40 ` Dennis Han
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.