All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kristoffer Eriksson <kristoffer.ericson@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 15/19] video: s1d13xxxfb: use dev_get_platdata()
Date: Tue, 17 Sep 2013 14:19:54 +0000	[thread overview]
Message-ID: <5238650A.2010203@gmail.com> (raw)
In-Reply-To: <001501ceb364$340fdf40$9c2f9dc0$%han@samsung.com>

Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>

Jingoo Han skrev 2013-09-17 07:10:
> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly. This is a cosmetic change
> to make the code simpler and enhance the readability.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>   drivers/video/s1d13xxxfb.c |   12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/s1d13xxxfb.c b/drivers/video/s1d13xxxfb.c
> index 05c2dc3..1399a46 100644
> --- a/drivers/video/s1d13xxxfb.c
> +++ b/drivers/video/s1d13xxxfb.c
> @@ -777,8 +777,8 @@ static int s1d13xxxfb_probe(struct platform_device *pdev)
>   	printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
>   
>   	/* enable platform-dependent hardware glue, if any */
> -	if (pdev->dev.platform_data)
> -		pdata = pdev->dev.platform_data;
> +	if (dev_get_platdata(&pdev->dev))
> +		pdata = dev_get_platdata(&pdev->dev);
>   
>   	if (pdata && pdata->platform_init_video)
>   		pdata->platform_init_video();
> @@ -923,8 +923,8 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
>   	lcd_enable(s1dfb, 0);
>   	crt_enable(s1dfb, 0);
>   
> -	if (dev->dev.platform_data)
> -		pdata = dev->dev.platform_data;
> +	if (dev_get_platdata(&dev->dev))
> +		pdata = dev_get_platdata(&dev->dev);
>   
>   #if 0
>   	if (!s1dfb->disp_save)
> @@ -973,8 +973,8 @@ static int s1d13xxxfb_resume(struct platform_device *dev)
>   	while ((s1d13xxxfb_readreg(s1dfb, S1DREG_PS_STATUS) & 0x01))
>   		udelay(10);
>   
> -	if (dev->dev.platform_data)
> -		pdata = dev->dev.platform_data;
> +	if (dev_get_platdata(&dev->dev))
> +		pdata = dev_get_platdata(&dev->dev);
>   
>   	if (s1dfb->regs_save) {
>   		/* will write RO regs, *should* get away with it :) */


      reply	other threads:[~2013-09-17 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  5:10 [PATCH 15/19] video: s1d13xxxfb: use dev_get_platdata() Jingoo Han
2013-09-17 14:19 ` Kristoffer Eriksson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5238650A.2010203@gmail.com \
    --to=kristoffer.ericson@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.