From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, patches@linaro.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/6] xen/arm: gic: Use the correct CPU ID
Date: Tue, 17 Sep 2013 16:04:22 +0100 [thread overview]
Message-ID: <52386F76.8020508@linaro.org> (raw)
In-Reply-To: <1379428575.11304.111.camel@hastur.hellion.org.uk>
On 09/17/2013 03:36 PM, Ian Campbell wrote:
> On Wed, 2013-09-11 at 12:59 +0100, Julien Grall wrote:
>> +static unsigned int gic_cpu_mask(const cpumask_t *cpumask)
>> +{
>> + unsigned int cpu;
>> + unsigned int mask = 0;
>> +
>> + for_each_cpu(cpu, cpumask)
>> + {
>> + ASSERT(cpu < NR_GIC_CPU_IF);
>> + mask = per_cpu(gic_cpu_id, cpu);
>
> Did you mean for this to be |= or something else?
Oh, right. I will update the patch and send it again.
--
Julien Grall
next prev parent reply other threads:[~2013-09-17 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 11:59 [PATCH v2 0/6] Dissociate logical and gic/hardware CPU ID Julien Grall
2013-09-11 11:59 ` [PATCH v2 1/6] xen/arm: use cpumask_t to describe cpu mask in gic_route_dt_irq Julien Grall
2013-09-11 11:59 ` [PATCH v2 2/6] xen/arm: Initialize correctly IRQ routing Julien Grall
2013-09-11 11:59 ` [PATCH v2 3/6] xen/arm: gic: Use the correct CPU ID Julien Grall
2013-09-17 14:36 ` Ian Campbell
2013-09-17 15:04 ` Julien Grall [this message]
2013-09-11 11:59 ` [PATCH v2 4/6] xen/arm: Fix assert in send_SGI_one Julien Grall
2013-09-11 11:59 ` [PATCH v2 5/6] xen/arm: Dissociate logical and hardware CPU ID Julien Grall
2013-09-17 14:39 ` Ian Campbell
2013-09-17 15:02 ` Julien Grall
2013-09-17 15:08 ` Ian Campbell
2013-09-17 15:18 ` Julien Grall
2013-09-17 15:25 ` Ian Campbell
2013-09-11 11:59 ` [PATCH v2 6/6] xen/arm: Use the hardware ID to boot correctly secondary cpus Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52386F76.8020508@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.