From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Tim Deegan <tim@xen.org>
Cc: Jacob Shin <jacob.shin@amd.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 3/9] passthrough/amd: Missing 'break'
Date: Tue, 17 Sep 2013 10:04:49 -0500 [thread overview]
Message-ID: <52386F91.30604@amd.com> (raw)
In-Reply-To: <1378988130-24172-4-git-send-email-tim@xen.org>
On 09/12/2013 07:15 AM, Tim Deegan wrote:
> Coverity CID 1055502
>
> Signed-off-by: Tim Deegan <tim@xen.org>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Cc: Jacob Shin <jacob.shin@amd.com>
> ---
> xen/drivers/passthrough/amd/iommu_guest.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c
> index 85f2361..952600a 100644
> --- a/xen/drivers/passthrough/amd/iommu_guest.c
> +++ b/xen/drivers/passthrough/amd/iommu_guest.c
> @@ -728,6 +728,7 @@ static void guest_iommu_mmio_write64(struct guest_iommu *iommu,
> break;
> case IOMMU_EVENT_LOG_BASE_LOW_OFFSET:
> u64_to_reg(&iommu->event_log.reg_base, val);
> + break;
> case IOMMU_PPR_LOG_BASE_LOW_OFFSET:
> u64_to_reg(&iommu->ppr_log.reg_base, val);
> break;
Acked-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
next prev parent reply other threads:[~2013-09-17 15:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 12:15 More Coverity-reported issues Tim Deegan
2013-09-12 12:15 ` [PATCH 1/9] x86/mm: Don't dereference p2m pointer before NULL check Tim Deegan
2013-09-12 12:15 ` [PATCH 2/9] passthrough/amd: Drop unnecessary lock lookup Tim Deegan
2013-09-12 13:35 ` Jan Beulich
2013-09-12 12:15 ` [PATCH 3/9] passthrough/amd: Missing 'break' Tim Deegan
2013-09-17 15:04 ` Suravee Suthikulpanit [this message]
2013-09-12 12:15 ` [PATCH 4/9] passthrough/amd: Shuffle declaration Tim Deegan
2013-09-12 13:38 ` Jan Beulich
2013-09-12 13:44 ` Tim Deegan
2013-09-12 14:03 ` Jan Beulich
2013-09-17 15:19 ` Suravee Suthikulpanit
2013-09-12 12:15 ` [PATCH 5/9] cpufreq: avoid integer overflows Tim Deegan
2013-09-12 13:49 ` Jan Beulich
2013-09-13 7:18 ` Liu, Jinsong
2013-09-12 12:15 ` [PATCH 6/9] cpufreq: missing check of copy_from_guest() Tim Deegan
2013-09-12 13:54 ` Jan Beulich
2013-09-13 7:18 ` Liu, Jinsong
2013-09-12 12:15 ` [PATCH 7/9] ehci-dbgp: avoid division by zero Tim Deegan
2013-09-12 13:55 ` Jan Beulich
2013-09-12 12:15 ` [PATCH 8/9] ehci-dbgp: drop dead code Tim Deegan
2013-09-12 14:01 ` Jan Beulich
2013-09-12 12:15 ` [PATCH 9/9] acpi/pmstat: fix check for empty name strings Tim Deegan
2013-09-12 14:02 ` Jan Beulich
2013-09-12 13:11 ` More Coverity-reported issues Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52386F91.30604@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=jacob.shin@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.