From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH 2/3] x86/AMD-Vi: Clean up code for handling IVRS IOAPIC override Date: Tue, 17 Sep 2013 10:06:06 -0500 Message-ID: <52386FDE.5000605@amd.com> References: <1379115031-1992-1-git-send-email-suravee.suthikulpanit@amd.com> <1379115031-1992-3-git-send-email-suravee.suthikulpanit@amd.com> <5236CF6902000078000F3812@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3060043068696586152==" Return-path: In-Reply-To: <5236CF6902000078000F3812@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============3060043068696586152== Content-Type: multipart/alternative; boundary="------------070102030101060203050208" --------------070102030101060203050208 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 09/16/2013 02:29 AM, Jan Beulich wrote: >>>> On 14.09.13 at 01:30, wrote: >> @@ -745,10 +745,7 @@ static u16 __init parse_ivhd_device_special( >> return 0; >> } >> >> - if ( test_bit(special->handle, ioapic_cmdline) ) >> - AMD_IOMMU_DEBUG("IVHD: Command line override present for IO-APIC %#x\n", >> - special->handle); >> - else if ( ioapic_sbdf[special->handle].pin_2_idx ) >> + if ( ioapic_sbdf[special->handle].pin_2_idx ) > Once again: Why is this unnecessary? > > Jan > > Ok... you are right. This part should handles the case when the IVRS entry has bad BDF. Suravee --------------070102030101060203050208 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 09/16/2013 02:29 AM, Jan Beulich wrote:
On 14.09.13 at 01:30, <suravee.suthikulpanit@amd.com> wrote:

@@ -745,10 +745,7 @@ static u16 __init parse_ivhd_device_special(
                 return 0;
             }
 
-            if ( test_bit(special->handle, ioapic_cmdline) )
-                AMD_IOMMU_DEBUG("IVHD: Command line override present for IO-APIC %#x\n",
-                                special->handle);
-            else if ( ioapic_sbdf[special->handle].pin_2_idx )
+            if ( ioapic_sbdf[special->handle].pin_2_idx )

Once again: Why is this unnecessary?

Jan
Ok... you are right.  This part should handles the case when the IVRS entry has bad BDF.

Suravee --------------070102030101060203050208-- --===============3060043068696586152== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3060043068696586152==--