* [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Just a bit late but here's the next trivial-patches pull request.
Thanks,
/mjt
The following changes since commit 2d1fe1873a984d1c2c89ffa3d12949cafc718551:
Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130910' into staging (2013-09-11 14:46:52 -0500)
are available in the git repository at:
git://git.corpit.ru/qemu.git trivial-patches
for you to fetch changes up to f47873f7d5a67ec8c5411abec9786beb8f691a46:
configure: Enable extra compiler warnings (2013-09-14 23:42:44 +0400)
----------------------------------------------------------------
Anthony PERARD (1):
docs: Fix IO port number for CPU present bitmap.
Markus Armbruster (1):
trace-events: Clean up with scripts/cleanup-trace-events.pl again
Michael Tokarev (2):
vscclient: remove unnecessary use of uninitialized variable
iov: avoid "orig_len may be used unitialized" warning
Michal Privoznik (1):
configure: Undefine _FORTIFY_SOURCE prior using it
Richard Henderson (1):
tcg-sparc: Fix parenthesis warning
Richard W.M. Jones (1):
q35: Fix typo in constant DEFUALT -> DEFAULT.
Stefan Weil (7):
*-user: Fix typo in comment (ulocking -> unlocking)
translate-all: Fix formatting of dump output
MAINTAINERS: Add missing entry to filelist for TCI target
*-user: Improve documentation for lock_user function
tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
Makefile: Remove some more files when cleaning
configure: Enable extra compiler warnings
Tobias Markus (1):
target-i386: Fix segment cache dump
MAINTAINERS | 1 +
Makefile | 4 +++-
bsd-user/qemu.h | 6 +++---
configure | 14 +++++++++-----
docs/specs/acpi_cpu_hotplug.txt | 2 +-
hw/pci-host/q35.c | 2 +-
include/hw/pci-host/q35.h | 2 +-
libcacard/vscclient.c | 3 +--
linux-user/qemu.h | 6 +++---
target-i386/helper.c | 4 +++-
tcg/sparc/tcg-target.h | 2 +-
tci.c | 12 ------------
trace-events | 3 +--
translate-all.c | 5 +++--
util/iov.c | 10 ++++------
15 files changed, 35 insertions(+), 41 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread* [Qemu-trivial] [PULL 01/15] configure: Undefine _FORTIFY_SOURCE prior using it
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori
Cc: qemu-trivial, Michal Privoznik, Jan Vesely, Michael Tokarev,
qemu-devel
From: Michal Privoznik <mprivozn@redhat.com>
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
previous detection if the macro has been already defined, e.g.
by environment, or is just enabled by compiler by default.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 2b83936..21451ba 100755
--- a/configure
+++ b/configure
@@ -3502,7 +3502,7 @@ if test "$gcov" = "yes" ; then
CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS"
LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
elif test "$debug" = "no" ; then
- CFLAGS="-O2 -D_FORTIFY_SOURCE=2 $CFLAGS"
+ CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
fi
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-devel] [PULL 01/15] configure: Undefine _FORTIFY_SOURCE prior using it
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori
Cc: qemu-trivial, Michal Privoznik, Jan Vesely, Michael Tokarev,
qemu-devel
From: Michal Privoznik <mprivozn@redhat.com>
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
previous detection if the macro has been already defined, e.g.
by environment, or is just enabled by compiler by default.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 2b83936..21451ba 100755
--- a/configure
+++ b/configure
@@ -3502,7 +3502,7 @@ if test "$gcov" = "yes" ; then
CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS"
LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
elif test "$debug" = "no" ; then
- CFLAGS="-O2 -D_FORTIFY_SOURCE=2 $CFLAGS"
+ CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
fi
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 02/15] q35: Fix typo in constant DEFUALT -> DEFAULT.
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, Richard W.M. Jones, qemu-devel
From: "Richard W.M. Jones" <rjones@redhat.com>
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/pci-host/q35.c | 2 +-
include/hw/pci-host/q35.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 5473504..0cb652d 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -372,7 +372,7 @@ static void mch_class_init(ObjectClass *klass, void *data)
dc->vmsd = &vmstate_mch;
k->vendor_id = PCI_VENDOR_ID_INTEL;
k->device_id = PCI_DEVICE_ID_INTEL_Q35_MCH;
- k->revision = MCH_HOST_BRIDGE_REVISION_DEFUALT;
+ k->revision = MCH_HOST_BRIDGE_REVISION_DEFAULT;
k->class_id = PCI_CLASS_BRIDGE_HOST;
}
diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
index 6eb7ab6..56de92e 100644
--- a/include/hw/pci-host/q35.h
+++ b/include/hw/pci-host/q35.h
@@ -85,7 +85,7 @@ typedef struct Q35PCIHost {
#define MCH_HOST_BRIDGE_CONFIG_DATA 0xcfc
/* D0:F0 configuration space */
-#define MCH_HOST_BRIDGE_REVISION_DEFUALT 0x0
+#define MCH_HOST_BRIDGE_REVISION_DEFAULT 0x0
#define MCH_HOST_BRIDGE_PCIEXBAR 0x60 /* 64bit register */
#define MCH_HOST_BRIDGE_PCIEXBAR_SIZE 8 /* 64bit register */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 02/15] q35: Fix typo in constant DEFUALT -> DEFAULT.
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, Richard W.M. Jones, qemu-devel
From: "Richard W.M. Jones" <rjones@redhat.com>
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/pci-host/q35.c | 2 +-
include/hw/pci-host/q35.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 5473504..0cb652d 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -372,7 +372,7 @@ static void mch_class_init(ObjectClass *klass, void *data)
dc->vmsd = &vmstate_mch;
k->vendor_id = PCI_VENDOR_ID_INTEL;
k->device_id = PCI_DEVICE_ID_INTEL_Q35_MCH;
- k->revision = MCH_HOST_BRIDGE_REVISION_DEFUALT;
+ k->revision = MCH_HOST_BRIDGE_REVISION_DEFAULT;
k->class_id = PCI_CLASS_BRIDGE_HOST;
}
diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
index 6eb7ab6..56de92e 100644
--- a/include/hw/pci-host/q35.h
+++ b/include/hw/pci-host/q35.h
@@ -85,7 +85,7 @@ typedef struct Q35PCIHost {
#define MCH_HOST_BRIDGE_CONFIG_DATA 0xcfc
/* D0:F0 configuration space */
-#define MCH_HOST_BRIDGE_REVISION_DEFUALT 0x0
+#define MCH_HOST_BRIDGE_REVISION_DEFAULT 0x0
#define MCH_HOST_BRIDGE_PCIEXBAR 0x60 /* 64bit register */
#define MCH_HOST_BRIDGE_PCIEXBAR_SIZE 8 /* 64bit register */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 03/15] docs: Fix IO port number for CPU present bitmap.
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: Anthony PERARD, qemu-trivial, Michael Tokarev, qemu-devel
From: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewd-By: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
docs/specs/acpi_cpu_hotplug.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
index 5dec0c5..f6f5774 100644
--- a/docs/specs/acpi_cpu_hotplug.txt
+++ b/docs/specs/acpi_cpu_hotplug.txt
@@ -10,7 +10,7 @@ ACPI GPE block (IO ports 0xafe0-0xafe3, byte access):
Generic ACPI GPE block. Bit 2 (GPE.2) used to notify CPU
hot-add/remove event to ACPI BIOS, via SCI interrupt.
-CPU present bitmap (IO port 0xaf00-0xae1f, 1-byte access):
+CPU present bitmap (IO port 0xaf00-0xaf1f, 1-byte access):
---------------------------------------------------------------
One bit per CPU. Bit position reflects corresponding CPU APIC ID.
Read-only.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-devel] [PULL 03/15] docs: Fix IO port number for CPU present bitmap.
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: Anthony PERARD, qemu-trivial, Michael Tokarev, qemu-devel
From: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewd-By: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
docs/specs/acpi_cpu_hotplug.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
index 5dec0c5..f6f5774 100644
--- a/docs/specs/acpi_cpu_hotplug.txt
+++ b/docs/specs/acpi_cpu_hotplug.txt
@@ -10,7 +10,7 @@ ACPI GPE block (IO ports 0xafe0-0xafe3, byte access):
Generic ACPI GPE block. Bit 2 (GPE.2) used to notify CPU
hot-add/remove event to ACPI BIOS, via SCI interrupt.
-CPU present bitmap (IO port 0xaf00-0xae1f, 1-byte access):
+CPU present bitmap (IO port 0xaf00-0xaf1f, 1-byte access):
---------------------------------------------------------------
One bit per CPU. Bit position reflects corresponding CPU APIC ID.
Read-only.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 04/15] *-user: Fix typo in comment (ulocking -> unlocking)
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
bsd-user/qemu.h | 2 +-
linux-user/qemu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 325f564..1f8ec6e 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -381,7 +381,7 @@ static inline void *lock_user_string(abi_ulong guest_addr)
return lock_user(VERIFY_READ, guest_addr, (long)(len + 1), 1);
}
-/* Helper macros for locking/ulocking a target struct. */
+/* Helper macros for locking/unlocking a target struct. */
#define lock_user_struct(type, host_ptr, guest_addr, copy) \
(host_ptr = lock_user(type, guest_addr, sizeof(*host_ptr), copy))
#define unlock_user_struct(host_ptr, guest_addr, copy) \
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 6ffe5a2..4422dfc 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -438,7 +438,7 @@ static inline void *lock_user_string(abi_ulong guest_addr)
return lock_user(VERIFY_READ, guest_addr, (long)(len + 1), 1);
}
-/* Helper macros for locking/ulocking a target struct. */
+/* Helper macros for locking/unlocking a target struct. */
#define lock_user_struct(type, host_ptr, guest_addr, copy) \
(host_ptr = lock_user(type, guest_addr, sizeof(*host_ptr), copy))
#define unlock_user_struct(host_ptr, guest_addr, copy) \
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 04/15] *-user: Fix typo in comment (ulocking -> unlocking)
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
bsd-user/qemu.h | 2 +-
linux-user/qemu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 325f564..1f8ec6e 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -381,7 +381,7 @@ static inline void *lock_user_string(abi_ulong guest_addr)
return lock_user(VERIFY_READ, guest_addr, (long)(len + 1), 1);
}
-/* Helper macros for locking/ulocking a target struct. */
+/* Helper macros for locking/unlocking a target struct. */
#define lock_user_struct(type, host_ptr, guest_addr, copy) \
(host_ptr = lock_user(type, guest_addr, sizeof(*host_ptr), copy))
#define unlock_user_struct(host_ptr, guest_addr, copy) \
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 6ffe5a2..4422dfc 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -438,7 +438,7 @@ static inline void *lock_user_string(abi_ulong guest_addr)
return lock_user(VERIFY_READ, guest_addr, (long)(len + 1), 1);
}
-/* Helper macros for locking/ulocking a target struct. */
+/* Helper macros for locking/unlocking a target struct. */
#define lock_user_struct(type, host_ptr, guest_addr, copy) \
(host_ptr = lock_user(type, guest_addr, sizeof(*host_ptr), copy))
#define unlock_user_struct(host_ptr, guest_addr, copy) \
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 05/15] translate-all: Fix formatting of dump output
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
The page dump writes a table with 3 abi_ulong values in each row.
These values take 8 or 16 characters (depending on sizeof abi_ulong).
Fix the table headings to be aligned with the table columns.
old:
start end size prot
0000000120000000-000000012021e000 000000000021e000 rwx
0000004000000000-0000004000002000 0000000000002000 ---
0000004000002000-0000004000802000 0000000000800000 rw-
new:
start end size prot
0000000120000000-000000012021e000 000000000021e000 rwx
0000004000000000-0000004000002000 0000000000002000 ---
0000004000002000-0000004000802000 0000000000800000 rw-
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
translate-all.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index 2c923c6..3b97c66 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1679,8 +1679,9 @@ static int dump_region(void *priv, abi_ulong start,
/* dump memory mappings */
void page_dump(FILE *f)
{
- (void) fprintf(f, "%-8s %-8s %-8s %s\n",
- "start", "end", "size", "prot");
+ const size_t length = sizeof(abi_ulong) * 2;
+ (void) fprintf(f, "%-*s %-*s %-*s %s\n",
+ length, "start", length, "end", length, "size", "prot");
walk_memory_regions(f, dump_region);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 05/15] translate-all: Fix formatting of dump output
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
The page dump writes a table with 3 abi_ulong values in each row.
These values take 8 or 16 characters (depending on sizeof abi_ulong).
Fix the table headings to be aligned with the table columns.
old:
start end size prot
0000000120000000-000000012021e000 000000000021e000 rwx
0000004000000000-0000004000002000 0000000000002000 ---
0000004000002000-0000004000802000 0000000000800000 rw-
new:
start end size prot
0000000120000000-000000012021e000 000000000021e000 rwx
0000004000000000-0000004000002000 0000000000002000 ---
0000004000002000-0000004000802000 0000000000800000 rw-
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
translate-all.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index 2c923c6..3b97c66 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1679,8 +1679,9 @@ static int dump_region(void *priv, abi_ulong start,
/* dump memory mappings */
void page_dump(FILE *f)
{
- (void) fprintf(f, "%-8s %-8s %-8s %s\n",
- "start", "end", "size", "prot");
+ const size_t length = sizeof(abi_ulong) * 2;
+ (void) fprintf(f, "%-*s %-*s %-*s %s\n",
+ length, "start", length, "end", length, "size", "prot");
walk_memory_regions(f, dump_region);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [Qemu-trivial] [PULL 05/15] translate-all: Fix formatting of dump output
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-17 17:59 ` Stefan Weil
-1 siblings, 0 replies; 40+ messages in thread
From: Stefan Weil @ 2013-09-17 17:59 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel, Anthony Liguori
Am 14.09.2013 21:47, schrieb Michael Tokarev:
> From: Stefan Weil <sw@weilnetz.de>
>
> The page dump writes a table with 3 abi_ulong values in each row.
> These values take 8 or 16 characters (depending on sizeof abi_ulong).
>
> Fix the table headings to be aligned with the table columns.
>
> old:
> start end size prot
> 0000000120000000-000000012021e000 000000000021e000 rwx
> 0000004000000000-0000004000002000 0000000000002000 ---
> 0000004000002000-0000004000802000 0000000000800000 rw-
>
> new:
> start end size prot
> 0000000120000000-000000012021e000 000000000021e000 rwx
> 0000004000000000-0000004000002000 0000000000002000 ---
> 0000004000002000-0000004000802000 0000000000800000 rw-
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> translate-all.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index 2c923c6..3b97c66 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1679,8 +1679,9 @@ static int dump_region(void *priv, abi_ulong start,
> /* dump memory mappings */
> void page_dump(FILE *f)
> {
> - (void) fprintf(f, "%-8s %-8s %-8s %s\n",
> - "start", "end", "size", "prot");
> + const size_t length = sizeof(abi_ulong) * 2;
> + (void) fprintf(f, "%-*s %-*s %-*s %s\n",
> + length, "start", length, "end", length, "size", "prot");
> walk_memory_regions(f, dump_region);
> }
>
Sorry, I just noticed that this patch causes compiler warnings on some
systems:
translate-all.c:1684:13: error: field width specifier ‘*’ expects
argument of type ‘int’, but argument 3 has type ‘size_t’ [-Werror=format]
translate-all.c:1684:13: error: field width specifier ‘*’ expects
argument of type ‘int’, but argument 5 has type ‘size_t’ [-Werror=format]
translate-all.c:1684:13: error: field width specifier ‘*’ expects
argument of type ‘int’, but argument 7 has type ‘size_t’ [-Werror=format]
Changing the type of variable 'length' to int fixes this:
+ const int length = sizeof(abi_ulong) * 2;
Regards,
Stefan
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [Qemu-devel] [PULL 05/15] translate-all: Fix formatting of dump output
@ 2013-09-17 17:59 ` Stefan Weil
0 siblings, 0 replies; 40+ messages in thread
From: Stefan Weil @ 2013-09-17 17:59 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel, Anthony Liguori
Am 14.09.2013 21:47, schrieb Michael Tokarev:
> From: Stefan Weil <sw@weilnetz.de>
>
> The page dump writes a table with 3 abi_ulong values in each row.
> These values take 8 or 16 characters (depending on sizeof abi_ulong).
>
> Fix the table headings to be aligned with the table columns.
>
> old:
> start end size prot
> 0000000120000000-000000012021e000 000000000021e000 rwx
> 0000004000000000-0000004000002000 0000000000002000 ---
> 0000004000002000-0000004000802000 0000000000800000 rw-
>
> new:
> start end size prot
> 0000000120000000-000000012021e000 000000000021e000 rwx
> 0000004000000000-0000004000002000 0000000000002000 ---
> 0000004000002000-0000004000802000 0000000000800000 rw-
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> translate-all.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index 2c923c6..3b97c66 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1679,8 +1679,9 @@ static int dump_region(void *priv, abi_ulong start,
> /* dump memory mappings */
> void page_dump(FILE *f)
> {
> - (void) fprintf(f, "%-8s %-8s %-8s %s\n",
> - "start", "end", "size", "prot");
> + const size_t length = sizeof(abi_ulong) * 2;
> + (void) fprintf(f, "%-*s %-*s %-*s %s\n",
> + length, "start", length, "end", length, "size", "prot");
> walk_memory_regions(f, dump_region);
> }
>
Sorry, I just noticed that this patch causes compiler warnings on some
systems:
translate-all.c:1684:13: error: field width specifier ‘*’ expects
argument of type ‘int’, but argument 3 has type ‘size_t’ [-Werror=format]
translate-all.c:1684:13: error: field width specifier ‘*’ expects
argument of type ‘int’, but argument 5 has type ‘size_t’ [-Werror=format]
translate-all.c:1684:13: error: field width specifier ‘*’ expects
argument of type ‘int’, but argument 7 has type ‘size_t’ [-Werror=format]
Changing the type of variable 'length' to int fixes this:
+ const int length = sizeof(abi_ulong) * 2;
Regards,
Stefan
^ permalink raw reply [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 06/15] MAINTAINERS: Add missing entry to filelist for TCI target
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
tci.c is also a maintained part of the TCI implementation.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d128ed0..4d634f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -842,6 +842,7 @@ TCI target
M: Stefan Weil <sw@weilnetz.de>
S: Maintained
F: tcg/tci/
+F: tci.c
Stable branches
---------------
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-devel] [PULL 06/15] MAINTAINERS: Add missing entry to filelist for TCI target
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
tci.c is also a maintained part of the TCI implementation.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d128ed0..4d634f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -842,6 +842,7 @@ TCI target
M: Stefan Weil <sw@weilnetz.de>
S: Maintained
F: tcg/tci/
+F: tci.c
Stable branches
---------------
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 07/15] *-user: Improve documentation for lock_user function
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Add a missing "function" and replace "and" by "any".
BSD and Linux use the same documentation here, so fix both.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
bsd-user/qemu.h | 4 ++--
linux-user/qemu.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 1f8ec6e..ddc74ed 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -323,9 +323,9 @@ abi_long copy_from_user(void *hptr, abi_ulong gaddr, size_t len);
abi_long copy_to_user(abi_ulong gaddr, void *hptr, size_t len);
/* Functions for accessing guest memory. The tget and tput functions
- read/write single values, byteswapping as necessary. The lock_user
+ read/write single values, byteswapping as necessary. The lock_user function
gets a pointer to a contiguous area of guest memory, but does not perform
- and byteswapping. lock_user may return either a pointer to the guest
+ any byteswapping. lock_user may return either a pointer to the guest
memory, or a temporary buffer. */
/* Lock an area of guest memory into the host. If copy is true then the
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 4422dfc..617cac1 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -380,9 +380,9 @@ abi_long copy_from_user(void *hptr, abi_ulong gaddr, size_t len);
abi_long copy_to_user(abi_ulong gaddr, void *hptr, size_t len);
/* Functions for accessing guest memory. The tget and tput functions
- read/write single values, byteswapping as necessary. The lock_user
+ read/write single values, byteswapping as necessary. The lock_user function
gets a pointer to a contiguous area of guest memory, but does not perform
- and byteswapping. lock_user may return either a pointer to the guest
+ any byteswapping. lock_user may return either a pointer to the guest
memory, or a temporary buffer. */
/* Lock an area of guest memory into the host. If copy is true then the
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 07/15] *-user: Improve documentation for lock_user function
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Add a missing "function" and replace "and" by "any".
BSD and Linux use the same documentation here, so fix both.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
bsd-user/qemu.h | 4 ++--
linux-user/qemu.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 1f8ec6e..ddc74ed 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -323,9 +323,9 @@ abi_long copy_from_user(void *hptr, abi_ulong gaddr, size_t len);
abi_long copy_to_user(abi_ulong gaddr, void *hptr, size_t len);
/* Functions for accessing guest memory. The tget and tput functions
- read/write single values, byteswapping as necessary. The lock_user
+ read/write single values, byteswapping as necessary. The lock_user function
gets a pointer to a contiguous area of guest memory, but does not perform
- and byteswapping. lock_user may return either a pointer to the guest
+ any byteswapping. lock_user may return either a pointer to the guest
memory, or a temporary buffer. */
/* Lock an area of guest memory into the host. If copy is true then the
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 4422dfc..617cac1 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -380,9 +380,9 @@ abi_long copy_from_user(void *hptr, abi_ulong gaddr, size_t len);
abi_long copy_to_user(abi_ulong gaddr, void *hptr, size_t len);
/* Functions for accessing guest memory. The tget and tput functions
- read/write single values, byteswapping as necessary. The lock_user
+ read/write single values, byteswapping as necessary. The lock_user function
gets a pointer to a contiguous area of guest memory, but does not perform
- and byteswapping. lock_user may return either a pointer to the guest
+ any byteswapping. lock_user may return either a pointer to the guest
memory, or a temporary buffer. */
/* Lock an area of guest memory into the host. If copy is true then the
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 08/15] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori
Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel,
qemu-stable
From: Stefan Weil <sw@weilnetz.de>
Debian busybox-static for alpha has a load address of 0x0000000120000000
which is mapped to 0x0000000020000000 for 32 bit hosts.
qemu-alpha uses the TCG opcodes qemu_ld32, qemu_ld64, qemu_st32 and
qemu_st64 which all raise the assertion (taddr == host_addr).
Remove all assertions of this type because they are either wrong or
unnecessary (when sizeof(tcg_target_ulong) >= sizeof(target_ulong)).
Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
tci.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/tci.c b/tci.c
index 18c888e..6d64891 100644
--- a/tci.c
+++ b/tci.c
@@ -1085,7 +1085,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp8 = *(uint8_t *)(host_addr + GUEST_BASE);
#endif
tci_write_reg8(t0, tmp8);
@@ -1097,7 +1096,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp8 = *(uint8_t *)(host_addr + GUEST_BASE);
#endif
tci_write_reg8s(t0, tmp8);
@@ -1109,7 +1107,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp16 = helper_ldw_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp16 = tswap16(*(uint16_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg16(t0, tmp16);
@@ -1121,7 +1118,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp16 = helper_ldw_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp16 = tswap16(*(uint16_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg16s(t0, tmp16);
@@ -1134,7 +1130,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp32 = helper_ldl_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp32 = tswap32(*(uint32_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg32(t0, tmp32);
@@ -1146,7 +1141,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp32 = helper_ldl_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp32 = tswap32(*(uint32_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg32s(t0, tmp32);
@@ -1159,7 +1153,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp32 = helper_ldl_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp32 = tswap32(*(uint32_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg32(t0, tmp32);
@@ -1174,7 +1167,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp64 = helper_ldq_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp64 = tswap64(*(uint64_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg(t0, tmp64);
@@ -1190,7 +1182,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stb_mmu(env, taddr, t0, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint8_t *)(host_addr + GUEST_BASE) = t0;
#endif
break;
@@ -1202,7 +1193,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stw_mmu(env, taddr, t0, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint16_t *)(host_addr + GUEST_BASE) = tswap16(t0);
#endif
break;
@@ -1214,7 +1204,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stl_mmu(env, taddr, t0, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint32_t *)(host_addr + GUEST_BASE) = tswap32(t0);
#endif
break;
@@ -1226,7 +1215,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stq_mmu(env, taddr, tmp64, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint64_t *)(host_addr + GUEST_BASE) = tswap64(tmp64);
#endif
break;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 08/15] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori
Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel,
qemu-stable
From: Stefan Weil <sw@weilnetz.de>
Debian busybox-static for alpha has a load address of 0x0000000120000000
which is mapped to 0x0000000020000000 for 32 bit hosts.
qemu-alpha uses the TCG opcodes qemu_ld32, qemu_ld64, qemu_st32 and
qemu_st64 which all raise the assertion (taddr == host_addr).
Remove all assertions of this type because they are either wrong or
unnecessary (when sizeof(tcg_target_ulong) >= sizeof(target_ulong)).
Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
tci.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/tci.c b/tci.c
index 18c888e..6d64891 100644
--- a/tci.c
+++ b/tci.c
@@ -1085,7 +1085,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp8 = *(uint8_t *)(host_addr + GUEST_BASE);
#endif
tci_write_reg8(t0, tmp8);
@@ -1097,7 +1096,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp8 = *(uint8_t *)(host_addr + GUEST_BASE);
#endif
tci_write_reg8s(t0, tmp8);
@@ -1109,7 +1107,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp16 = helper_ldw_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp16 = tswap16(*(uint16_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg16(t0, tmp16);
@@ -1121,7 +1118,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp16 = helper_ldw_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp16 = tswap16(*(uint16_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg16s(t0, tmp16);
@@ -1134,7 +1130,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp32 = helper_ldl_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp32 = tswap32(*(uint32_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg32(t0, tmp32);
@@ -1146,7 +1141,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp32 = helper_ldl_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp32 = tswap32(*(uint32_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg32s(t0, tmp32);
@@ -1159,7 +1153,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp32 = helper_ldl_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp32 = tswap32(*(uint32_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg32(t0, tmp32);
@@ -1174,7 +1167,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
tmp64 = helper_ldq_mmu(env, taddr, tci_read_i(&tb_ptr));
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
tmp64 = tswap64(*(uint64_t *)(host_addr + GUEST_BASE));
#endif
tci_write_reg(t0, tmp64);
@@ -1190,7 +1182,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stb_mmu(env, taddr, t0, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint8_t *)(host_addr + GUEST_BASE) = t0;
#endif
break;
@@ -1202,7 +1193,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stw_mmu(env, taddr, t0, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint16_t *)(host_addr + GUEST_BASE) = tswap16(t0);
#endif
break;
@@ -1214,7 +1204,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stl_mmu(env, taddr, t0, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint32_t *)(host_addr + GUEST_BASE) = tswap32(t0);
#endif
break;
@@ -1226,7 +1215,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
helper_stq_mmu(env, taddr, tmp64, t2);
#else
host_addr = (tcg_target_ulong)taddr;
- assert(taddr == host_addr);
*(uint64_t *)(host_addr + GUEST_BASE) = tswap64(tmp64);
#endif
break;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 09/15] trace-events: Clean up with scripts/cleanup-trace-events.pl again
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, Markus Armbruster, qemu-devel
From: Markus Armbruster <armbru@redhat.com>
Event qxl_render_blit_guest_primary_initialized is unused since commit
c58c7b9, drop it.
Commit 42e5b4c moved hw/ppc/xics.c to hw/intc/xics.c without updating
the comment in trace-events.
"scripts/cleanup-trace-events.pl trace-events | diff trace-events" is
now clean again.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
trace-events | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/trace-events b/trace-events
index d4dba24..9a1347b 100644
--- a/trace-events
+++ b/trace-events
@@ -1109,7 +1109,6 @@ qemu_spice_wakeup(uint32_t qid) "%d"
qemu_spice_create_update(uint32_t left, uint32_t right, uint32_t top, uint32_t bottom) "lr %d -> %d, tb -> %d -> %d"
# hw/display/qxl-render.c
-qxl_render_blit_guest_primary_initialized(void) ""
qxl_render_blit(int32_t stride, int32_t left, int32_t right, int32_t top, int32_t bottom) "stride=%d [%d, %d, %d, %d]"
qxl_render_guest_primary_resized(int32_t width, int32_t height, int32_t stride, int32_t bytes_pp, int32_t bits_pp) "%dx%d, stride %d, bpp %d, depth %d"
qxl_render_update_area_done(void *cookie) "%p"
@@ -1122,7 +1121,7 @@ spapr_pci_rtas_ibm_query_interrupt_source_number(unsigned ioa, unsigned intr) "q
spapr_pci_msi_write(uint64_t addr, uint64_t data, uint32_t dt_irq) "@%"PRIx64"<=%"PRIx64" IRQ %u"
spapr_pci_lsi_set(const char *busname, int pin, uint32_t irq) "%s PIN%d IRQ %u"
-# hw/ppc/xics.c
+# hw/intc/xics.c
xics_icp_check_ipi(int server, uint8_t mfrr) "CPU %d can take IPI mfrr=%#x"
xics_icp_accept(uint32_t old_xirr, uint32_t new_xirr) "icp_accept: XIRR %#"PRIx32"->%#"PRIx32
xics_icp_eoi(int server, uint32_t xirr, uint32_t new_xirr) "icp_eoi: server %d given XIRR %#"PRIx32" new XIRR %#"PRIx32
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-devel] [PULL 09/15] trace-events: Clean up with scripts/cleanup-trace-events.pl again
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, Markus Armbruster, qemu-devel
From: Markus Armbruster <armbru@redhat.com>
Event qxl_render_blit_guest_primary_initialized is unused since commit
c58c7b9, drop it.
Commit 42e5b4c moved hw/ppc/xics.c to hw/intc/xics.c without updating
the comment in trace-events.
"scripts/cleanup-trace-events.pl trace-events | diff trace-events" is
now clean again.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
trace-events | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/trace-events b/trace-events
index d4dba24..9a1347b 100644
--- a/trace-events
+++ b/trace-events
@@ -1109,7 +1109,6 @@ qemu_spice_wakeup(uint32_t qid) "%d"
qemu_spice_create_update(uint32_t left, uint32_t right, uint32_t top, uint32_t bottom) "lr %d -> %d, tb -> %d -> %d"
# hw/display/qxl-render.c
-qxl_render_blit_guest_primary_initialized(void) ""
qxl_render_blit(int32_t stride, int32_t left, int32_t right, int32_t top, int32_t bottom) "stride=%d [%d, %d, %d, %d]"
qxl_render_guest_primary_resized(int32_t width, int32_t height, int32_t stride, int32_t bytes_pp, int32_t bits_pp) "%dx%d, stride %d, bpp %d, depth %d"
qxl_render_update_area_done(void *cookie) "%p"
@@ -1122,7 +1121,7 @@ spapr_pci_rtas_ibm_query_interrupt_source_number(unsigned ioa, unsigned intr) "q
spapr_pci_msi_write(uint64_t addr, uint64_t data, uint32_t dt_irq) "@%"PRIx64"<=%"PRIx64" IRQ %u"
spapr_pci_lsi_set(const char *busname, int pin, uint32_t irq) "%s PIN%d IRQ %u"
-# hw/ppc/xics.c
+# hw/intc/xics.c
xics_icp_check_ipi(int server, uint8_t mfrr) "CPU %d can take IPI mfrr=%#x"
xics_icp_accept(uint32_t old_xirr, uint32_t new_xirr) "icp_accept: XIRR %#"PRIx32"->%#"PRIx32
xics_icp_eoi(int server, uint32_t xirr, uint32_t new_xirr) "icp_eoi: server %d given XIRR %#"PRIx32" new XIRR %#"PRIx32
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 10/15] vscclient: remove unnecessary use of uninitialized variable
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel, Wenchao Xia
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
libcacard/vscclient.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index 5180d29..a3cb776 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -645,7 +645,6 @@ main(
GIOChannel *channel_stdin;
char *qemu_host;
char *qemu_port;
- VSCMsgHeader mhHeader;
VCardEmulOptions *command_line_options = NULL;
@@ -754,7 +753,7 @@ main(
.magic = VSCARD_MAGIC,
.capabilities = {0}
};
- send_msg(VSC_Init, mhHeader.reader_id, &init, sizeof(init));
+ send_msg(VSC_Init, 0, &init, sizeof(init));
g_main_loop_run(loop);
g_main_loop_unref(loop);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 10/15] vscclient: remove unnecessary use of uninitialized variable
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel, Wenchao Xia
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
libcacard/vscclient.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index 5180d29..a3cb776 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -645,7 +645,6 @@ main(
GIOChannel *channel_stdin;
char *qemu_host;
char *qemu_port;
- VSCMsgHeader mhHeader;
VCardEmulOptions *command_line_options = NULL;
@@ -754,7 +753,7 @@ main(
.magic = VSCARD_MAGIC,
.capabilities = {0}
};
- send_msg(VSC_Init, mhHeader.reader_id, &init, sizeof(init));
+ send_msg(VSC_Init, 0, &init, sizeof(init));
g_main_loop_run(loop);
g_main_loop_unref(loop);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 11/15] iov: avoid "orig_len may be used unitialized" warning
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel, Wenchao Xia
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
util/iov.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/util/iov.c b/util/iov.c
index f705586..bb46c04 100644
--- a/util/iov.c
+++ b/util/iov.c
@@ -181,13 +181,11 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
assert(iov[niov].iov_len > tail);
orig_len = iov[niov].iov_len;
iov[niov++].iov_len = tail;
- }
-
- ret = do_send_recv(sockfd, iov, niov, do_send);
-
- /* Undo the changes above before checking for errors */
- if (tail) {
+ ret = do_send_recv(sockfd, iov, niov, do_send);
+ /* Undo the changes above before checking for errors */
iov[niov-1].iov_len = orig_len;
+ } else {
+ ret = do_send_recv(sockfd, iov, niov, do_send);
}
if (offset) {
iov[0].iov_base -= offset;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 11/15] iov: avoid "orig_len may be used unitialized" warning
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel, Wenchao Xia
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
util/iov.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/util/iov.c b/util/iov.c
index f705586..bb46c04 100644
--- a/util/iov.c
+++ b/util/iov.c
@@ -181,13 +181,11 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
assert(iov[niov].iov_len > tail);
orig_len = iov[niov].iov_len;
iov[niov++].iov_len = tail;
- }
-
- ret = do_send_recv(sockfd, iov, niov, do_send);
-
- /* Undo the changes above before checking for errors */
- if (tail) {
+ ret = do_send_recv(sockfd, iov, niov, do_send);
+ /* Undo the changes above before checking for errors */
iov[niov-1].iov_len = orig_len;
+ } else {
+ ret = do_send_recv(sockfd, iov, niov, do_send);
}
if (offset) {
iov[0].iov_base -= offset;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 12/15] target-i386: Fix segment cache dump
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: Tobias Markus, qemu-trivial, Michael Tokarev, qemu-devel
From: Tobias Markus <tobias@markus-regensburg.de>
When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default
operation size bit (D/B bit) is not set for Long Mode Data Segments since
there are only Data Segments in Long Mode and no explicit 16/32/64-bit
Descriptors.
This patch fixes this by checking the Long Mode Active bit of the hidden
flags variable and logging "DS" if it is set. (I.e. in Long Mode all Data
Segments are logged as "DS")
Signed-off-by: Tobias Markus <tobias@markus-regensburg.de>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
target-i386/helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 7c58e27..eef3334 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -147,7 +147,9 @@ cpu_x86_dump_seg_cache(CPUX86State *env, FILE *f, fprintf_function cpu_fprintf,
cpu_fprintf(f, " [%c%c", (sc->flags & DESC_C_MASK) ? 'C' : '-',
(sc->flags & DESC_R_MASK) ? 'R' : '-');
} else {
- cpu_fprintf(f, (sc->flags & DESC_B_MASK) ? "DS " : "DS16");
+ cpu_fprintf(f,
+ (sc->flags & DESC_B_MASK || env->hflags & HF_LMA_MASK)
+ ? "DS " : "DS16");
cpu_fprintf(f, " [%c%c", (sc->flags & DESC_E_MASK) ? 'E' : '-',
(sc->flags & DESC_W_MASK) ? 'W' : '-');
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 12/15] target-i386: Fix segment cache dump
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: Tobias Markus, qemu-trivial, Michael Tokarev, qemu-devel
From: Tobias Markus <tobias@markus-regensburg.de>
When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default
operation size bit (D/B bit) is not set for Long Mode Data Segments since
there are only Data Segments in Long Mode and no explicit 16/32/64-bit
Descriptors.
This patch fixes this by checking the Long Mode Active bit of the hidden
flags variable and logging "DS" if it is set. (I.e. in Long Mode all Data
Segments are logged as "DS")
Signed-off-by: Tobias Markus <tobias@markus-regensburg.de>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
target-i386/helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 7c58e27..eef3334 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -147,7 +147,9 @@ cpu_x86_dump_seg_cache(CPUX86State *env, FILE *f, fprintf_function cpu_fprintf,
cpu_fprintf(f, " [%c%c", (sc->flags & DESC_C_MASK) ? 'C' : '-',
(sc->flags & DESC_R_MASK) ? 'R' : '-');
} else {
- cpu_fprintf(f, (sc->flags & DESC_B_MASK) ? "DS " : "DS16");
+ cpu_fprintf(f,
+ (sc->flags & DESC_B_MASK || env->hflags & HF_LMA_MASK)
+ ? "DS " : "DS16");
cpu_fprintf(f, " [%c%c", (sc->flags & DESC_E_MASK) ? 'E' : '-',
(sc->flags & DESC_W_MASK) ? 'W' : '-');
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 13/15] Makefile: Remove some more files when cleaning
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 362fe3e..f6da5fe 100644
--- a/Makefile
+++ b/Makefile
@@ -236,7 +236,8 @@ clean:
find . -name '*.[oda]' -type f -exec rm -f {} +
find . -name '*.l[oa]' -type f -exec rm -f {} +
rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
- rm -Rf .libs
+ rm -f fsdev/*.pod
+ rm -rf .libs */.libs
rm -f qemu-img-cmds.h
@# May not be present in GENERATED_HEADERS
rm -f trace/generated-tracers-dtrace.dtrace*
@@ -261,6 +262,7 @@ qemu-%.tar.bz2:
distclean: clean
rm -f config-host.mak config-host.h* config-host.ld $(DOCS) qemu-options.texi qemu-img-cmds.texi qemu-monitor.texi
rm -f config-all-devices.mak config-all-disas.mak
+ rm -f po/*.mo
rm -f roms/seabios/config.mak roms/vgabios/config.mak
rm -f qemu-doc.info qemu-doc.aux qemu-doc.cp qemu-doc.cps qemu-doc.dvi
rm -f qemu-doc.fn qemu-doc.fns qemu-doc.info qemu-doc.ky qemu-doc.kys
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 13/15] Makefile: Remove some more files when cleaning
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 362fe3e..f6da5fe 100644
--- a/Makefile
+++ b/Makefile
@@ -236,7 +236,8 @@ clean:
find . -name '*.[oda]' -type f -exec rm -f {} +
find . -name '*.l[oa]' -type f -exec rm -f {} +
rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
- rm -Rf .libs
+ rm -f fsdev/*.pod
+ rm -rf .libs */.libs
rm -f qemu-img-cmds.h
@# May not be present in GENERATED_HEADERS
rm -f trace/generated-tracers-dtrace.dtrace*
@@ -261,6 +262,7 @@ qemu-%.tar.bz2:
distclean: clean
rm -f config-host.mak config-host.h* config-host.ld $(DOCS) qemu-options.texi qemu-img-cmds.texi qemu-monitor.texi
rm -f config-all-devices.mak config-all-disas.mak
+ rm -f po/*.mo
rm -f roms/seabios/config.mak roms/vgabios/config.mak
rm -f qemu-doc.info qemu-doc.aux qemu-doc.cp qemu-doc.cps qemu-doc.dvi
rm -f qemu-doc.fn qemu-doc.fns qemu-doc.info qemu-doc.ky qemu-doc.kys
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 14/15] tcg-sparc: Fix parenthesis warning
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel, Richard Henderson
From: Richard Henderson <rth@twiddle.net>
error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
tcg/sparc/tcg-target.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h
index 2edf858..1ff2922 100644
--- a/tcg/sparc/tcg-target.h
+++ b/tcg/sparc/tcg-target.h
@@ -153,7 +153,7 @@ typedef enum {
static inline void flush_icache_range(uintptr_t start, uintptr_t stop)
{
uintptr_t p;
- for (p = start & -8; p < (stop + 7) & -8; p += 8) {
+ for (p = start & -8; p < ((stop + 7) & -8); p += 8) {
__asm__ __volatile__("flush\t%0" : : "r" (p));
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 14/15] tcg-sparc: Fix parenthesis warning
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel, Richard Henderson
From: Richard Henderson <rth@twiddle.net>
error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
tcg/sparc/tcg-target.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h
index 2edf858..1ff2922 100644
--- a/tcg/sparc/tcg-target.h
+++ b/tcg/sparc/tcg-target.h
@@ -153,7 +153,7 @@ typedef enum {
static inline void flush_icache_range(uintptr_t start, uintptr_t stop)
{
uintptr_t p;
- for (p = start & -8; p < (stop + 7) & -8; p += 8) {
+ for (p = start & -8; p < ((stop + 7) & -8); p += 8) {
__asm__ __volatile__("flush\t%0" : : "r" (p));
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [Qemu-trivial] [PULL 15/15] configure: Enable extra compiler warnings
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-14 19:47 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Compiler option -Wextra enables an additional set of compiler warnings.
Some of these warnings were already enabled explicitly in QEMU:
-Wold-style-declaration, -Wtype-limits, -Wignored-qualifiers and
-Wempty-body are now redundant and can be removed.
Others don't work with the current code and must be disabled to
avoid warnings: -Wno-missing-field-initializers, -Wno-override-init,
-Wno-sign-compare and -Wno-unused-parameter.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
configure | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 21451ba..a17cac7 100755
--- a/configure
+++ b/configure
@@ -310,7 +310,7 @@ sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
# default flags for all hosts
QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
-QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
+QEMU_CFLAGS="-Wall -Wextra -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
QEMU_INCLUDES="-I. -I\$(SRC_PATH) -I\$(SRC_PATH)/include"
@@ -1236,12 +1236,16 @@ if test -z "$werror" ; then
fi
fi
-gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
-gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags"
-gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
+gcc_flags="-Wold-style-definition"
+gcc_flags="-Wformat-security -Wformat-y2k -Winit-self $gcc_flags"
+gcc_flags="-Wmissing-include-dirs -Wnested-externs $gcc_flags"
gcc_flags="-Wendif-labels $gcc_flags"
gcc_flags="-Wno-initializer-overrides $gcc_flags"
+gcc_flags="-Wno-missing-field-initializers $gcc_flags"
+gcc_flags="-Wno-override-init $gcc_flags"
+gcc_flags="-Wno-sign-compare $gcc_flags"
gcc_flags="-Wno-string-plus-int $gcc_flags"
+gcc_flags="-Wno-unused-parameter $gcc_flags"
# Note that we do not add -Werror to gcc_flags here, because that would
# enable it for all configure tests. If a configure test failed due
# to -Werror this would just silently disable some features,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread* [Qemu-devel] [PULL 15/15] configure: Enable extra compiler warnings
@ 2013-09-14 19:47 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-14 19:47 UTC (permalink / raw)
To: aliguori; +Cc: qemu-trivial, Stefan Weil, Michael Tokarev, qemu-devel
From: Stefan Weil <sw@weilnetz.de>
Compiler option -Wextra enables an additional set of compiler warnings.
Some of these warnings were already enabled explicitly in QEMU:
-Wold-style-declaration, -Wtype-limits, -Wignored-qualifiers and
-Wempty-body are now redundant and can be removed.
Others don't work with the current code and must be disabled to
avoid warnings: -Wno-missing-field-initializers, -Wno-override-init,
-Wno-sign-compare and -Wno-unused-parameter.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
configure | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 21451ba..a17cac7 100755
--- a/configure
+++ b/configure
@@ -310,7 +310,7 @@ sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
# default flags for all hosts
QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
-QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
+QEMU_CFLAGS="-Wall -Wextra -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
QEMU_INCLUDES="-I. -I\$(SRC_PATH) -I\$(SRC_PATH)/include"
@@ -1236,12 +1236,16 @@ if test -z "$werror" ; then
fi
fi
-gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
-gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags"
-gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
+gcc_flags="-Wold-style-definition"
+gcc_flags="-Wformat-security -Wformat-y2k -Winit-self $gcc_flags"
+gcc_flags="-Wmissing-include-dirs -Wnested-externs $gcc_flags"
gcc_flags="-Wendif-labels $gcc_flags"
gcc_flags="-Wno-initializer-overrides $gcc_flags"
+gcc_flags="-Wno-missing-field-initializers $gcc_flags"
+gcc_flags="-Wno-override-init $gcc_flags"
+gcc_flags="-Wno-sign-compare $gcc_flags"
gcc_flags="-Wno-string-plus-int $gcc_flags"
+gcc_flags="-Wno-unused-parameter $gcc_flags"
# Note that we do not add -Werror to gcc_flags here, because that would
# enable it for all configure tests. If a configure test failed due
# to -Werror this would just silently disable some features,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14
2013-09-14 19:47 ` [Qemu-devel] " Michael Tokarev
@ 2013-09-17 15:06 ` Anthony Liguori
-1 siblings, 0 replies; 40+ messages in thread
From: Anthony Liguori @ 2013-09-17 15:06 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Just a bit late but here's the next trivial-patches pull request.
>
> Thanks,
Breaks the build:
/home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
/home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
/home/anthony/git/qemu/cpu-exec.c:202:28: error: argument ‘env’ might
be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
cc1: all warnings being treated as errors
I think it's one of the warning patches from Stefan. I cannot bisect
here. My gcc info is below:
[10:05 AM] anthony🐵 titi:~/build/qemu$ gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gcc-4.6.real
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.6.1/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro
4.6.1-9ubuntu3'
--with-bugurl=file:///usr/share/doc/gcc-4.6/README.Bugs
--enable-languages=c,c++,fortran,objc,obj-c++,go --prefix=/usr
--program-suffix=-4.6 --enable-shared --enable-linker-build-id
--with-system-zlib --libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.6
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-plugin
--enable-objc-gc --disable-werror --with-arch-32=i686
--with-tune=generic --enable-checking=release --build=x86_64-linux-gnu
--host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.6.1 (Ubuntu/Linaro 4.6.1-9ubuntu3)
Regards,
Anthony Liguori
>
> /mjt
>
> The following changes since commit 2d1fe1873a984d1c2c89ffa3d12949cafc718551:
>
> Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130910' into staging (2013-09-11 14:46:52 -0500)
>
> are available in the git repository at:
>
> git://git.corpit.ru/qemu.git trivial-patches
>
> for you to fetch changes up to f47873f7d5a67ec8c5411abec9786beb8f691a46:
>
> configure: Enable extra compiler warnings (2013-09-14 23:42:44 +0400)
>
> ----------------------------------------------------------------
> Anthony PERARD (1):
> docs: Fix IO port number for CPU present bitmap.
>
> Markus Armbruster (1):
> trace-events: Clean up with scripts/cleanup-trace-events.pl again
>
> Michael Tokarev (2):
> vscclient: remove unnecessary use of uninitialized variable
> iov: avoid "orig_len may be used unitialized" warning
>
> Michal Privoznik (1):
> configure: Undefine _FORTIFY_SOURCE prior using it
>
> Richard Henderson (1):
> tcg-sparc: Fix parenthesis warning
>
> Richard W.M. Jones (1):
> q35: Fix typo in constant DEFUALT -> DEFAULT.
>
> Stefan Weil (7):
> *-user: Fix typo in comment (ulocking -> unlocking)
> translate-all: Fix formatting of dump output
> MAINTAINERS: Add missing entry to filelist for TCI target
> *-user: Improve documentation for lock_user function
> tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
> Makefile: Remove some more files when cleaning
> configure: Enable extra compiler warnings
>
> Tobias Markus (1):
> target-i386: Fix segment cache dump
>
> MAINTAINERS | 1 +
> Makefile | 4 +++-
> bsd-user/qemu.h | 6 +++---
> configure | 14 +++++++++-----
> docs/specs/acpi_cpu_hotplug.txt | 2 +-
> hw/pci-host/q35.c | 2 +-
> include/hw/pci-host/q35.h | 2 +-
> libcacard/vscclient.c | 3 +--
> linux-user/qemu.h | 6 +++---
> target-i386/helper.c | 4 +++-
> tcg/sparc/tcg-target.h | 2 +-
> tci.c | 12 ------------
> trace-events | 3 +--
> translate-all.c | 5 +++--
> util/iov.c | 10 ++++------
> 15 files changed, 35 insertions(+), 41 deletions(-)
>
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14
@ 2013-09-17 15:06 ` Anthony Liguori
0 siblings, 0 replies; 40+ messages in thread
From: Anthony Liguori @ 2013-09-17 15:06 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Just a bit late but here's the next trivial-patches pull request.
>
> Thanks,
Breaks the build:
/home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
/home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
/home/anthony/git/qemu/cpu-exec.c:202:28: error: argument ‘env’ might
be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
cc1: all warnings being treated as errors
I think it's one of the warning patches from Stefan. I cannot bisect
here. My gcc info is below:
[10:05 AM] anthony🐵 titi:~/build/qemu$ gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gcc-4.6.real
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.6.1/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro
4.6.1-9ubuntu3'
--with-bugurl=file:///usr/share/doc/gcc-4.6/README.Bugs
--enable-languages=c,c++,fortran,objc,obj-c++,go --prefix=/usr
--program-suffix=-4.6 --enable-shared --enable-linker-build-id
--with-system-zlib --libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.6
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-plugin
--enable-objc-gc --disable-werror --with-arch-32=i686
--with-tune=generic --enable-checking=release --build=x86_64-linux-gnu
--host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.6.1 (Ubuntu/Linaro 4.6.1-9ubuntu3)
Regards,
Anthony Liguori
>
> /mjt
>
> The following changes since commit 2d1fe1873a984d1c2c89ffa3d12949cafc718551:
>
> Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130910' into staging (2013-09-11 14:46:52 -0500)
>
> are available in the git repository at:
>
> git://git.corpit.ru/qemu.git trivial-patches
>
> for you to fetch changes up to f47873f7d5a67ec8c5411abec9786beb8f691a46:
>
> configure: Enable extra compiler warnings (2013-09-14 23:42:44 +0400)
>
> ----------------------------------------------------------------
> Anthony PERARD (1):
> docs: Fix IO port number for CPU present bitmap.
>
> Markus Armbruster (1):
> trace-events: Clean up with scripts/cleanup-trace-events.pl again
>
> Michael Tokarev (2):
> vscclient: remove unnecessary use of uninitialized variable
> iov: avoid "orig_len may be used unitialized" warning
>
> Michal Privoznik (1):
> configure: Undefine _FORTIFY_SOURCE prior using it
>
> Richard Henderson (1):
> tcg-sparc: Fix parenthesis warning
>
> Richard W.M. Jones (1):
> q35: Fix typo in constant DEFUALT -> DEFAULT.
>
> Stefan Weil (7):
> *-user: Fix typo in comment (ulocking -> unlocking)
> translate-all: Fix formatting of dump output
> MAINTAINERS: Add missing entry to filelist for TCI target
> *-user: Improve documentation for lock_user function
> tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
> Makefile: Remove some more files when cleaning
> configure: Enable extra compiler warnings
>
> Tobias Markus (1):
> target-i386: Fix segment cache dump
>
> MAINTAINERS | 1 +
> Makefile | 4 +++-
> bsd-user/qemu.h | 6 +++---
> configure | 14 +++++++++-----
> docs/specs/acpi_cpu_hotplug.txt | 2 +-
> hw/pci-host/q35.c | 2 +-
> include/hw/pci-host/q35.h | 2 +-
> libcacard/vscclient.c | 3 +--
> linux-user/qemu.h | 6 +++---
> target-i386/helper.c | 4 +++-
> tcg/sparc/tcg-target.h | 2 +-
> tci.c | 12 ------------
> trace-events | 3 +--
> translate-all.c | 5 +++--
> util/iov.c | 10 ++++------
> 15 files changed, 35 insertions(+), 41 deletions(-)
>
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14
2013-09-17 15:06 ` Anthony Liguori
@ 2013-09-17 16:38 ` Stefan Weil
-1 siblings, 0 replies; 40+ messages in thread
From: Stefan Weil @ 2013-09-17 16:38 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Am 17.09.2013 17:06, schrieb Anthony Liguori:
> On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Just a bit late but here's the next trivial-patches pull request.
>>
>> Thanks,
> Breaks the build:
>
> /home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
> /home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> /home/anthony/git/qemu/cpu-exec.c:202:28: error: argument ‘env’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> cc1: all warnings being treated as errors
>
> I think it's one of the warning patches from Stefan. I cannot bisect
> here. My gcc info is below:
Yes, it's the new -Wextra compiler (see "configure: Enable extra
compiler warnings").
Some versions of gcc complain about this code in cpu-exec.c:
/* Reload env after longjmp - the compiler may have smashed all
* local variables as longjmp is marked 'noreturn'. */
cpu = current_cpu;
env = cpu->env_ptr;
I think that lines can be simply removed (which also fixes the warning).
Please apply the trivial patches without my -Wextra patch or wait until
I have sent a patch to fix cpu-exec.c.
Regards
Stefan
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14
@ 2013-09-17 16:38 ` Stefan Weil
0 siblings, 0 replies; 40+ messages in thread
From: Stefan Weil @ 2013-09-17 16:38 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Am 17.09.2013 17:06, schrieb Anthony Liguori:
> On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Just a bit late but here's the next trivial-patches pull request.
>>
>> Thanks,
> Breaks the build:
>
> /home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
> /home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> /home/anthony/git/qemu/cpu-exec.c:202:28: error: argument ‘env’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> cc1: all warnings being treated as errors
>
> I think it's one of the warning patches from Stefan. I cannot bisect
> here. My gcc info is below:
Yes, it's the new -Wextra compiler (see "configure: Enable extra
compiler warnings").
Some versions of gcc complain about this code in cpu-exec.c:
/* Reload env after longjmp - the compiler may have smashed all
* local variables as longjmp is marked 'noreturn'. */
cpu = current_cpu;
env = cpu->env_ptr;
I think that lines can be simply removed (which also fixes the warning).
Please apply the trivial patches without my -Wextra patch or wait until
I have sent a patch to fix cpu-exec.c.
Regards
Stefan
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14
2013-09-17 15:06 ` Anthony Liguori
@ 2013-09-18 8:19 ` Michael Tokarev
-1 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-18 8:19 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
17.09.2013 19:06, Anthony Liguori wrote:
> On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Just a bit late but here's the next trivial-patches pull request.
>>
>> Thanks,
>
> Breaks the build:
>
> /home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
> /home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
Which system do you use to compile stuff? I verified the series on a few
versions of Debian and on a FreeBSD system, none shows any bad stuff.
I'd like to test on a system similar to what you use to avoid breakage
in the future.
Speaking of this series, is it okay if I'll rebase with fixups and
re-send the pull request?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14
@ 2013-09-18 8:19 ` Michael Tokarev
0 siblings, 0 replies; 40+ messages in thread
From: Michael Tokarev @ 2013-09-18 8:19 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
17.09.2013 19:06, Anthony Liguori wrote:
> On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Just a bit late but here's the next trivial-patches pull request.
>>
>> Thanks,
>
> Breaks the build:
>
> /home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
> /home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
Which system do you use to compile stuff? I verified the series on a few
versions of Debian and on a FreeBSD system, none shows any bad stuff.
I'd like to test on a system similar to what you use to avoid breakage
in the future.
Speaking of this series, is it okay if I'll rebase with fixups and
re-send the pull request?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 40+ messages in thread