All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Mark Brown <broonie@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulator: fix fatal kernel-doc error
Date: Tue, 17 Sep 2013 10:09:24 -0700	[thread overview]
Message-ID: <52388CC4.7040101@infradead.org> (raw)
In-Reply-To: <20130917103238.GM21013@sirena.org.uk>

On 09/17/13 03:32, Mark Brown wrote:
> On Mon, Sep 16, 2013 at 06:08:02PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix fatal kernel-doc error in <linux/regulator/driver.h>:
>>
>> Error(include/linux/regulator/driver.h:52): cannot understand prototype: 'struct regulator_linear_range '
> 
> Applied with the first line redone, but this seems like really terrible
> quality of implementation for the kernel-doc stuff - it shouldn't
> explode over something readily copable with like this.  Should we also
> not pick this sort of thing up in -next?

/** means kernel-doc syntax and it was not in proper kernel-doc format,
but maybe it could just be a Warning instead of a fatal Error.

Ideally we should pick it up in -next, of course, but I doubt that anyone
is running kernel-doc on linux-next.  I used to do that, but there are
too many errors/warnings.  I suppose that I could just concentrate on
(fatal) Errors in linux-next and ignore the Warnings.

-- 
~Randy

  reply	other threads:[~2013-09-17 17:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  1:08 [PATCH] regulator: fix fatal kernel-doc error Randy Dunlap
2013-09-17 10:32 ` Mark Brown
2013-09-17 17:09   ` Randy Dunlap [this message]
2013-09-17 19:23     ` Mark Brown
2013-09-17 23:33       ` Fengguang Wu
2013-09-19 14:01         ` Mark Brown
2013-09-19 15:26           ` Fengguang Wu
2013-09-19 15:52             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52388CC4.7040101@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.