All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: rongqing.li@windriver.com
Cc: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds
Date: Tue, 17 Sep 2013 20:56:29 -0500	[thread overview]
Message-ID: <5239084D.4020802@redhat.com> (raw)
In-Reply-To: <1379466661-27973-1-git-send-email-rongqing.li@windriver.com>

Change the suffix rule to ensure that version.h is 
built before we try to create any .o file.

Reported-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

I dunno, does this work?  My gnu make is rusty.

diff --git a/Makefile b/Makefile
index 3d715d8..d25054f 100644
--- a/Makefile
+++ b/Makefile
@@ -107,13 +107,13 @@ endif
 %.o.d: %.c
 	$(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
 
-.c.o:
+%.o: %.c version.h
 	@$(check_echo) "    [SP]     $<"
 	$(Q)$(check) $(AM_CFLAGS) $(CFLAGS) $<
 	@echo "    [CC]     $@"
 	$(Q)$(CC) $(AM_CFLAGS) $(CFLAGS) -c $<
 
-%.static.o: %.c
+%.static.o: %.c version.h
 	@echo "    [CC]     $@"
 	$(Q)$(CC) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
 

  parent reply	other threads:[~2013-09-18  1:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18  1:11 [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue rongqing.li
2013-09-18  1:51 ` Eric Sandeen
2013-09-18  1:55   ` Rongqing Li
2013-09-23  7:17   ` Rongqing Li
2013-09-18  1:56 ` Eric Sandeen [this message]
2013-09-18  2:26   ` [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds Eric Sandeen
2013-09-18  6:39     ` Rongqing Li
2013-09-18 14:51 ` [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue David Sterba
2013-09-22  1:06   ` Rongqing Li
2013-09-23 12:26     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5239084D.4020802@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=rongqing.li@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.