From: "H. Peter Anvin" <hpa@zytor.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: Useless inode var and Coding style fixes
Date: Tue, 17 Sep 2013 19:29:12 -0700 [thread overview]
Message-ID: <52390FF8.4080202@zytor.com> (raw)
In-Reply-To: <1379470942-4084-1-git-send-email-geyslan@gmail.com>
On 09/17/2013 07:22 PM, Geyslan G. Bem wrote:
> file size read only one time: useless prior value allocation.
> It's not necessary to verify f_op in the load_aout_library, since the
> prior kernel_read/vfs_read function already does.
> Coding style and printk strings fixes.
>
> Tested using qemu, a handcrafted a.out binary and a a.out linked with a
> cross-compiled ld.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> fs/binfmt_aout.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
This is not an x86 patch.
The other one is only because we effectively have a copy of the a.out
code in the ia32 directory, but it too can go through the generic route
with my ack.
-hpa
next prev parent reply other threads:[~2013-09-18 2:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 2:22 [PATCH 2/2] x86: Useless inode var and Coding style fixes Geyslan G. Bem
2013-09-18 2:29 ` H. Peter Anvin [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 2:54 [PATCH 1/2] x86_64: Add safe check in a.out loaders and some coding style Geyslan G. Bem
2013-09-18 2:54 ` [PATCH 2/2] x86: Useless inode var and Coding style fixes Geyslan G. Bem
2013-09-18 5:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52390FF8.4080202@zytor.com \
--to=hpa@zytor.com \
--cc=geyslan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.