All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xie XiuQi <xiexiuqi@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@elte.hu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] clocksource: fix misleading comment for __clocksource_updatefreq_scale()
Date: Wed, 18 Sep 2013 10:57:01 +0800	[thread overview]
Message-ID: <5239167D.7090404@huawei.com> (raw)

Functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz()
mentioned in the comment of __clocksource_updatefreq_scale() do not exist.

As Thomas Gleixner's suggestion, I renamed the functions and the few call
sites because the underscores are completely meaningless.

Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/clocksource/cadence_ttc_timer.c | 2 +-
 drivers/clocksource/em_sti.c            | 2 +-
 drivers/clocksource/sh_cmt.c            | 2 +-
 drivers/clocksource/sh_tmu.c            | 2 +-
 include/linux/clocksource.h             | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/cadence_ttc_timer.c b/drivers/clocksource/cadence_ttc_timer.c
index 4cbe28c..05f00e7 100644
--- a/drivers/clocksource/cadence_ttc_timer.c
+++ b/drivers/clocksource/cadence_ttc_timer.c
@@ -226,7 +226,7 @@ static int ttc_rate_change_clocksource_cb(struct notifier_block *nb,
 		 * Do whatever is necessary to maintain a proper time base
 		 *
 		 * I cannot find a way to adjust the currently used clocksource
-		 * to the new frequency. __clocksource_updatefreq_hz() sounds
+		 * to the new frequency. clocksource_updatefreq_hz() sounds
 		 * good, but does not work. Not sure what's that missing.
 		 *
 		 * This approach works, but triggers two clocksource switches.
diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
index 4329a29..ccbb513 100644
--- a/drivers/clocksource/em_sti.c
+++ b/drivers/clocksource/em_sti.c
@@ -210,7 +210,7 @@ static int em_sti_clocksource_enable(struct clocksource *cs)

 	ret = em_sti_start(p, USER_CLOCKSOURCE);
 	if (!ret)
-		__clocksource_updatefreq_hz(cs, p->rate);
+		clocksource_updatefreq_hz(cs, p->rate);
 	return ret;
 }

diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index 08d0c41..dc812c5 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -504,7 +504,7 @@ static int sh_cmt_clocksource_enable(struct clocksource *cs)

 	ret = sh_cmt_start(p, FLAG_CLOCKSOURCE);
 	if (!ret) {
-		__clocksource_updatefreq_hz(cs, p->rate);
+		clocksource_updatefreq_hz(cs, p->rate);
 		p->cs_enabled = true;
 	}
 	return ret;
diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
index 78b8dae..be4ae3e 100644
--- a/drivers/clocksource/sh_tmu.c
+++ b/drivers/clocksource/sh_tmu.c
@@ -236,7 +236,7 @@ static int sh_tmu_clocksource_enable(struct clocksource *cs)

 	ret = sh_tmu_enable(p);
 	if (!ret) {
-		__clocksource_updatefreq_hz(cs, p->rate);
+		clocksource_updatefreq_hz(cs, p->rate);
 		p->cs_enabled = true;
 	}

diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index dbbf8aa..87e8aa0 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -314,12 +314,12 @@ static inline int clocksource_register_khz(struct clocksource *cs, u32 khz)
 	return __clocksource_register_scale(cs, 1000, khz);
 }

-static inline void __clocksource_updatefreq_hz(struct clocksource *cs, u32 hz)
+static inline void clocksource_updatefreq_hz(struct clocksource *cs, u32 hz)
 {
 	__clocksource_updatefreq_scale(cs, 1, hz);
 }

-static inline void __clocksource_updatefreq_khz(struct clocksource *cs, u32 khz)
+static inline void clocksource_updatefreq_khz(struct clocksource *cs, u32 khz)
 {
 	__clocksource_updatefreq_scale(cs, 1000, khz);
 }
-- 
1.8.2.1



             reply	other threads:[~2013-09-18  2:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18  2:57 Xie XiuQi [this message]
2013-10-09 23:35 ` [PATCH v2] clocksource: fix misleading comment for __clocksource_updatefreq_scale() John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5239167D.7090404@huawei.com \
    --to=xiexiuqi@huawei.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.