From: Andrzej Hajda <a.hajda@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Vikas Sajjan <vikas.sajjan@linaro.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [drm/exynos-fimd] Display regression in v3.12-rc1
Date: Wed, 18 Sep 2013 08:48:23 +0200 [thread overview]
Message-ID: <52394CB7.7080509@samsung.com> (raw)
In-Reply-To: <CAK9yfHxnDxRA-Aew6RiGACTr6YKPCXx3JTGPU5nuNaOCZu8OEw@mail.gmail.com>
Hi Sachin,
Could you test it with removed display-timings::clock-frequency property.
Currently in arch/arm/boot/dts/exynos4210-origen.dts
display-timings::clock-frequency is set to 50000,
this is incorrect value. With the property removed fimd calculates
clock-frequency from other properties with assumption of default
60Hz refresh rate.
It could work before because of_get_fb_videomode calculated refresh rate
from display-timings and with clock 50000, the result was 0(due to
rounding down in some division),
so fimd assumed he should use default refresh rate of 60Hz.
Regards
Andrzej
On 09/18/2013 07:22 AM, Sachin Kamat wrote:
> Hi Andrzej ,
>
> I was testing the latest Linux kernel release (v3.12-rc1) on
> Exynos4210 based Origen board.
> I found a display regression with that. I do not get any display on
> the LCD (other than backlight) with the latest kernel. Git bisect
> pointed me to the following commit:
> 111e6055d4e0d35c6a4b6cd37d7bb00a88eaffb4 ("drm/exynos: fimd: replace
> struct fb_videomode with videomode"). Reverting this patch does not
> cause the issue. Let me know if you need any other info to help
> identify the problem.
>
next prev parent reply other threads:[~2013-09-18 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 5:22 [drm/exynos-fimd] Display regression in v3.12-rc1 Sachin Kamat
2013-09-18 6:48 ` Andrzej Hajda [this message]
2013-09-18 8:15 ` Sachin Kamat
2013-09-18 8:31 ` Andrzej Hajda
2013-09-20 6:42 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52394CB7.7080509@samsung.com \
--to=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sachin.kamat@linaro.org \
--cc=vikas.sajjan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.