From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c:zynq: I2C multi-bus support on Zynq
Date: Wed, 18 Sep 2013 09:13:45 +0200 [thread overview]
Message-ID: <523952A9.3040705@denx.de> (raw)
In-Reply-To: <EFBFAB0BC299D345A30F813A3C85DA8701252A9A@EDPR-EX01.logicpd.com>
Hello Michael,
a "How to send patches", Jagan Teki responded to you, so I only comment
your patch ...
Am 17.09.2013 19:29, schrieb Michael Burr:
> Zynq PS has two I2C bus masters (called 'I2C0' and 'I2C1'):
>> Implement 'i2c_set_bus_num' routine to select from these.
> Support I2C devices which do not use internal addresses:
>> Handle case of 'alen == 0' in 'i2c_read', 'i2c_write'.
> This supports PCA9548 bus multiplexer on Xilinx ZC702 board.
> Tested cases of 'alen == 0' and 'alen == 1' on this board.
> Further minor corrections:
>> Write 'address' register before 'data' register.
>> Write 'transfer_size' register before 'address' register.
>
> Signed-off-by: Michael Burr<michael.burr@logicpd.com>
> Cc: Albert Aribaud<albert.u.boot@aribaud.net>
> Cc: Heiko Schocher<hs@denx.de>
> Cc: Michal Simek<monstr@monstr.eu>
> ---
> drivers/i2c/zynq_i2c.c | 87 ++++++++++++++++++++++++++++++------------------
> 1 file changed, 55 insertions(+), 32 deletions(-)
Thanks for your work!
But please use the new i2c multibus/multiadapter framework for adding
multibus support for this driver. Currently 4 i2c drivers are ported
to this new framework, see:
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=880540decfb855e96bc14ac84ac7784669e4b382
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=1f2ba722ac06393d6abe6d4734824d3b98ea9108
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=00f792e0df9ae942427e44595a0f4379582accee
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=ea818dbbcd59300b56014ac2d67798a54994eb9b
You can use them as a base for your work
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2013-09-18 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 17:29 [U-Boot] [PATCH] i2c:zynq: I2C multi-bus support on Zynq Michael Burr
2013-09-18 7:13 ` Heiko Schocher [this message]
2013-09-18 15:01 ` Michael Burr
-- strict thread matches above, loose matches on Subject: below --
2013-09-20 20:40 Michael Burr
2013-09-22 7:32 ` Heiko Schocher
2013-09-23 15:07 ` Michael Burr
2013-09-24 8:30 ` Michal Simek
2013-09-24 14:58 ` Michael Burr
2013-09-24 15:19 ` Michal Simek
2013-09-24 15:25 ` Michael Burr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523952A9.3040705@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.