From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VMCTQ-0008F3-Ls
	for qemu-devel@nongnu.org; Wed, 18 Sep 2013 03:47:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VMCTH-0002z2-08
	for qemu-devel@nongnu.org; Wed, 18 Sep 2013 03:46:56 -0400
Received: from mail-pd0-f179.google.com ([209.85.192.179]:33974)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VMCTG-0002yj-Nh
	for qemu-devel@nongnu.org; Wed, 18 Sep 2013 03:46:46 -0400
Received: by mail-pd0-f179.google.com with SMTP id v10so6670160pde.38
	for <qemu-devel@nongnu.org>; Wed, 18 Sep 2013 00:46:45 -0700 (PDT)
Message-ID: <52395A5E.2010006@ozlabs.ru>
Date: Wed, 18 Sep 2013 17:46:38 +1000
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1379478118-20448-1-git-send-email-aik@ozlabs.ru>
	<CAFEAcA9o5CQcSFNtCsJdLEeH=nipXta=bDsz6CwdAe0NSbZORQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9o5CQcSFNtCsJdLEeH=nipXta=bDsz6CwdAe0NSbZORQ@mail.gmail.com>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] kvm: add set_one_reg/get_one_reg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On 09/18/2013 05:14 PM, Peter Maydell wrote:
> On 18 September 2013 05:21, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>  include/sysemu/kvm.h |  4 ++++
>>  kvm-all.c            | 31 +++++++++++++++++++++++++++++++
>>  2 files changed, 35 insertions(+)
>>
>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
>> index c7bc07b..b2d61e9 100644
>> --- a/include/sysemu/kvm.h
>> +++ b/include/sysemu/kvm.h
>> @@ -319,4 +319,8 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>>  void kvm_pc_gsi_handler(void *opaque, int n, int level);
>>  void kvm_pc_setup_irq_routing(bool pci_enabled);
>>  void kvm_init_irq_routing(KVMState *s);
>> +
>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
> 
> Doc comments, please.

What comments? Do not the function names speak for themselves already?



-- 
Alexey