Re: [Powertop] [PATCH] embed self-contained javascript

[Jose Luis Rivas <ghostbar at debian.org>]

[-- Attachment #1: Type: text/plain, Size: 2989 bytes --]

On 09/18/2013 03:36 AM, Sergey Senozhatsky wrote:
> On (09/17/13 16:44), Jose Luis Rivas wrote:
>> On 09/17/2013 03:11 PM, Sergey Senozhatsky wrote:
>>
>>
>>
>> BTW, trying to apply this patch I saw the src/Makefile.am makes a call
>> to `src/csstoh.sh` which does not exists in the codebase. So it throws
>> errors applying this patch to Debian.
> 
> hm, src/csstoh.sh exists in the codebase. where did you get source
> code from?
> 
>> ```
>> make[3]: Entering directory `/tmp/buildd/powertop-2.4/src'
>> /bin/bash ./csstoh.sh powertop.css css.h
>> /bin/bash: ./csstoh.sh: No such file or directory
>> make[3]: *** [css.h] Error 127
>> make[3]: Leaving directory `/tmp/buildd/powertop-2.4/src'
>> make[2]: *** [all-recursive] Error 1
>> make[2]: Leaving directory `/tmp/buildd/powertop-2.4'
>> make[1]: *** [all] Error 2
>> make[1]: Leaving directory `/tmp/buildd/powertop-2.4'
>> dh_auto_build: make -j1 returned exit code 2
>> make: *** [build] Error 2
>> dpkg-buildpackage: error: debian/rules build gave error exit status 2
>> ```
>>
>> I guess it comes because of the change in the CSS so it needs to
>> update the `src/css.h`.
> 
> css.h is generated from css file
> 
> 	$(SHELL) ./csstoh.sh powertop.css css.h
> 
> 	-ss
> 

This is what we use in conjuction with uscan to get the sources (from
debian/watch[0]):
```
version=3
https://01.org/powertop/downloads
https://01.org/powertop/sites/default/files/downloads/powertop-([\d\.]*).tar.gz
```

I downloaded the tar.gz from the source site and made an ls into src,
this is the result:

8<---
 ghostbar  ⋯  powertop  wget
https://01.org/powertop/sites/default/files/downloads/powertop-2.4.tar.gz
--2013-09-18 03:48:50--
https://01.org/powertop/sites/default/files/downloads/powertop-2.4.tar.gz
Resolving 01.org (01.org)... 198.145.11.105, 2001:19d0:3:5::105
Connecting to 01.org (01.org)|198.145.11.105|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 632390 (618K) [application/x-gzip]
Saving to: ‘powertop-2.4.tar.gz’

100%[================================================================================================================================>]
632,390      174KB/s   in 3.6s

2013-09-18 03:48:55 (174 KB/s) - ‘powertop-2.4.tar.gz’ saved [632390/632390]

 ghostbar  ⋯  powertop  tar -zxf powertop-2.4.tar.gz
 ghostbar  ⋯  powertop  ls powertop-2.4/src
calibrate  css.h    devlist.cpp  display.cpp  lib.cpp  main.cpp
Makefile.in  parameters  powertop.css  report
cpu        devices  devlist.h    display.h    lib.h    Makefile.am
measurement  perf        process       tuning
 ghostbar  ⋯  powertop  ls powertop-2.4/src | grep csstoh
 ghostbar  ⋯  powertop 

--->8

Kind regards.

[0] https://github.com/ghostbar/powertop.deb/blob/master/debian/watch

-- 
The Debian Project - http://debian.org/
Jose Luis Rivas - http://joseluisrivas.net/#ghostbar