From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas KANDAGATLA Subject: Re: [PATCH v3] media: st-rc: Add ST remote control driver Date: Wed, 18 Sep 2013 11:11:29 +0100 Message-ID: <52397C51.1020608@st.com> References: <1377778012-873-1-git-send-email-srinivas.kandagatla@st.com> <20130916141049.GE30650@e106331-lin.cambridge.arm.com> Reply-To: srinivas.kandagatla-qxv4g6HH51o@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130916141049.GE30650-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: "linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mauro Carvalho Chehab , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Pawel Moll , Stephen Warren , Ian Campbell , Rob Landley , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" List-Id: devicetree@vger.kernel.org Thanks Mark, On 16/09/13 15:10, Mark Rutland wrote: >> + >> > +Required properties: >> > + - compatible: should be "st,comms-irb". > This should probably say "should contain" rather than "should be". There > may be future vairants of this device, which will also have a more > specific compatible string. Ok, will change it to the suggest. > >> > + - reg: base physical address of the controller and length of memory >> > + mapped region. >> > + - interrupts: interrupt number to the cpu. The interrupt specifier >> > + format depends on the interrupt controller parent. > I don't like the phrase "interrupt number to the cpu". We already have > the term interrupt-specifier to precisely define this. How about: > > - interrupts: interrupt-specifier for the sole interrupt generated by > the device. > TBH, I did copy them from one of the existing bindings docs. I will change it. >> > + >> > +Optional properties: >> > + - rx-mode: can be "infrared" or "uhf". >> > + - tx-mode: should be "infrared". > Are these required to use rx/tx? Yes, these are required for driver to be in rx/tx mode. One of them can be optional depending on the board setup. So, Is it ok to move such properties to required properties section? > > If you don't have a tx-mode or rx-mode, I assume you can't do > anything... Yes, driver errs out. > >> > + - pinctrl-names, pinctrl-0: the pincontrol settings to configure >> > + muxing properly for IRB pins. > If we're expecting names, the names we expect should be defined. > >> > + - clocks : phandle of clock. > This is not just a phandle. This is a phandle + clock-specifier pair. Yep, will change it. Thanks, srini > > Cheers, -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eu1sys200aog108.obsmtp.com ([207.126.144.125]:48590 "EHLO eu1sys200aog108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343Ab3IRKcN (ORCPT ); Wed, 18 Sep 2013 06:32:13 -0400 Message-ID: <52397C51.1020608@st.com> Date: Wed, 18 Sep 2013 11:11:29 +0100 From: Srinivas KANDAGATLA Reply-To: srinivas.kandagatla@st.com MIME-Version: 1.0 To: Mark Rutland Cc: "linux-media@vger.kernel.org" , Mauro Carvalho Chehab , "linux-doc@vger.kernel.org" , "devicetree@vger.kernel.org" , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , Rob Landley , "grant.likely@linaro.org" Subject: Re: [PATCH v3] media: st-rc: Add ST remote control driver References: <1377778012-873-1-git-send-email-srinivas.kandagatla@st.com> <20130916141049.GE30650@e106331-lin.cambridge.arm.com> In-Reply-To: <20130916141049.GE30650@e106331-lin.cambridge.arm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Thanks Mark, On 16/09/13 15:10, Mark Rutland wrote: >> + >> > +Required properties: >> > + - compatible: should be "st,comms-irb". > This should probably say "should contain" rather than "should be". There > may be future vairants of this device, which will also have a more > specific compatible string. Ok, will change it to the suggest. > >> > + - reg: base physical address of the controller and length of memory >> > + mapped region. >> > + - interrupts: interrupt number to the cpu. The interrupt specifier >> > + format depends on the interrupt controller parent. > I don't like the phrase "interrupt number to the cpu". We already have > the term interrupt-specifier to precisely define this. How about: > > - interrupts: interrupt-specifier for the sole interrupt generated by > the device. > TBH, I did copy them from one of the existing bindings docs. I will change it. >> > + >> > +Optional properties: >> > + - rx-mode: can be "infrared" or "uhf". >> > + - tx-mode: should be "infrared". > Are these required to use rx/tx? Yes, these are required for driver to be in rx/tx mode. One of them can be optional depending on the board setup. So, Is it ok to move such properties to required properties section? > > If you don't have a tx-mode or rx-mode, I assume you can't do > anything... Yes, driver errs out. > >> > + - pinctrl-names, pinctrl-0: the pincontrol settings to configure >> > + muxing properly for IRB pins. > If we're expecting names, the names we expect should be defined. > >> > + - clocks : phandle of clock. > This is not just a phandle. This is a phandle + clock-specifier pair. Yep, will change it. Thanks, srini > > Cheers,