diff for duplicates of <5239829F.4080601@t-online.de> diff --git a/a/1.txt b/N1/1.txt index 300e917..97b2f86 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -30,7 +30,7 @@ At that place the error message is already emitted. > * due to large numbers of GFP_NOFS allocations causing the Have a look at the attached patch. It fixes my problem with the erroneous/misleading -error messages, and I think it´s right to just bail out early if SHRINK_STOP is found. +error messages, and I think it's right to just bail out early if SHRINK_STOP is found. Do you agree ? diff --git a/a/2.txt b/N1/2.txt index 9027ab2..8b13789 100644 --- a/a/2.txt +++ b/N1/2.txt @@ -1,36 +1 @@ ->From 75ae570ce7b0bb6b40c76beb18fc075e9af3127a Mon Sep 17 00:00:00 2001 -From: Knut Petersen <Knut_Petersen@t-online.de> -Date: Wed, 18 Sep 2013 12:06:33 +0200 -Subject: [PATCH] mm: respect SHRINK_STOP in shrink_slab_node() -Since commit 81e49f811404f428a9d9a63295a0c267e802fa12 -i915_gem_inactive_count() might return SHRINK_STOP. - -Unfortunately SHRINK_STOP is not handled propperly in -shrink_slab_node(), causing a system log cluttered with -kernel error messages complaining about "negative objects -to delete". - -I think the proper way of handling SHRINK_STOP is obvious, -we should obey ;-) - -Signed-off-by: Knut Petersen <Knut_Petersen@t-online.de> ---- - mm/vmscan.c | 2 ++ - 1 file changed, 2 insertions(+) - -diff --git a/mm/vmscan.c b/mm/vmscan.c -index 8ed1b77..b1e6f0d 100644 ---- a/mm/vmscan.c -+++ b/mm/vmscan.c -@@ -244,6 +244,8 @@ shrink_slab_node(struct shrink_control *shrinkctl, struct shrinker *shrinker, - max_pass = shrinker->count_objects(shrinker, shrinkctl); - if (max_pass == 0) - return 0; -+ if (max_pass == SHRINK_STOP) -+ return 0; - - /* - * copy the current shrinker scan count into a local variable --- -1.8.1.4 diff --git a/a/content_digest b/N1/content_digest index 316eb4f..5414748 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -48,7 +48,7 @@ "> \t\t * due to large numbers of GFP_NOFS allocations causing the\n" "\n" "Have a look at the attached patch. It fixes my problem with the erroneous/misleading\n" - "error messages, and I think it\302\264s right to just bail out early if SHRINK_STOP is found.\n" + "error messages, and I think it's right to just bail out early if SHRINK_STOP is found.\n" "\n" "Do you agree ?\n" "\n" @@ -57,41 +57,5 @@ "\01:2\0" "fn\00001-mm-respect-SHRINK_STOP-in-shrink_slab_node.patch\0" "b\0" - ">From 75ae570ce7b0bb6b40c76beb18fc075e9af3127a Mon Sep 17 00:00:00 2001\n" - "From: Knut Petersen <Knut_Petersen@t-online.de>\n" - "Date: Wed, 18 Sep 2013 12:06:33 +0200\n" - "Subject: [PATCH] mm: respect SHRINK_STOP in shrink_slab_node()\n" - "\n" - "Since commit 81e49f811404f428a9d9a63295a0c267e802fa12\n" - "i915_gem_inactive_count() might return SHRINK_STOP.\n" - "\n" - "Unfortunately SHRINK_STOP is not handled propperly in\n" - "shrink_slab_node(), causing a system log cluttered with\n" - "kernel error messages complaining about \"negative objects\n" - "to delete\".\n" - "\n" - "I think the proper way of handling SHRINK_STOP is obvious,\n" - "we should obey ;-)\n" - "\n" - "Signed-off-by: Knut Petersen <Knut_Petersen@t-online.de>\n" - "---\n" - " mm/vmscan.c | 2 ++\n" - " 1 file changed, 2 insertions(+)\n" - "\n" - "diff --git a/mm/vmscan.c b/mm/vmscan.c\n" - "index 8ed1b77..b1e6f0d 100644\n" - "--- a/mm/vmscan.c\n" - "+++ b/mm/vmscan.c\n" - "@@ -244,6 +244,8 @@ shrink_slab_node(struct shrink_control *shrinkctl, struct shrinker *shrinker,\n" - " \tmax_pass = shrinker->count_objects(shrinker, shrinkctl);\n" - " \tif (max_pass == 0)\n" - " \t\treturn 0;\n" - "+\tif (max_pass == SHRINK_STOP)\n" - "+\t\treturn 0;\n" - " \n" - " \t/*\n" - " \t * copy the current shrinker scan count into a local variable\n" - "-- \n" - 1.8.1.4 -575c33ff782ccc02d9c6f7b0571d09f98b5e9b12b3b92c2932a1ba30f8ee5a12 +cc78d6e48f8d48589f2edf89bcade1f0489d89516dc468faf809dfefcbbade05
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.