From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 5/5] B4860QDS: Add support of 2 stage NAND boot loader
Date: Wed, 18 Sep 2013 16:45:50 +0530 [thread overview]
Message-ID: <52398B66.1070902@freescale.com> (raw)
In-Reply-To: <loom.20130917T234026-64@post.gmane.org>
Thanks Rommel for checking this patch.
Please find my reply in-lined
On 09/18/2013 03:28 AM, Rommel Custodio wrote:
> Dear Prabhakar Kushwaha,
>
> Prabhakar Kushwaha <prabhakar <at> freescale.com> writes:
>
>> Add support of 2 stage NAND boot loader using SPL framework.
>> here, PBL initialise the internal SRAM and copy SPL(96K). This further
>> initialise DDR using SPD and environment and copy u-boot(512 kb) from NAND
> to DDR.
>> Finally SPL transer control to u-boot.
>
> These are just some quick comments after a build test and a quick code
> review.
> The environment is latest with some patches from patchworks.
>
> 1) Your code does not build with
> http://patchwork.ozlabs.org/patch/274193/
>
> powerpc-linux-objcopy --gap-fill=0xff -O binary
> /export/home/git.denx.de/local/obj-B4860QDS_NAND/u-boot
> /export/home/git.denx.de/local/obj-B4860QDS_NAND/u-boot.bin
> /export/home/git.denx.de/local/obj-B4860QDS_NAND/tools/mkimage -n \
> -R -T pblimage \
> -d /export/home/git.denx.de/local/obj-B4860QDS_NAND/u-
> boot.bin /export/home//git.denx.de/local/obj-B4860QDS_NAND/u-boot.pbl
> Error:-R - Can't open
> make: *** [/export/home/git.denx.de/local/obj-B4860QDS_NAND/u-boot.pbl]
> Error 1
>
> You mention you use the PBL... but probably not a pblimage. The patch
> correctly fixes RAMBOOT_PBL as a trigger to generate the pblimage (u-
> boot.pbl) but there seems to be no RCW or PBI file defined.
B4860 does support PBL based NAND boot.
but I have yet to integrate u-boot-spl.bin to generated u-boot-spl.pbl.
This is in my TODO list
>
> 2) Use the new SPDX identifiers
> http://patchwork.ozlabs.org/patch/261356/
Sure
> This was mainlined a few revisions ago.
>
>
> 3) Watch out for the new boards.cfg layout
>
>
I will take care of it while providing the patch.
> I have one question, can this scenario be implemented on a P5040? i.e.
> simulate that CPC is around 128Kb and load u-boot via SPL? Now all corenet
> processors seem to only support pblimage booting.
>
yes. This scenario can be implemented for P5040. Only need to create
spl.c file + define constants.
Thanks,
Prabhakar
next prev parent reply other threads:[~2013-09-18 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 16:05 [U-Boot] [RFC 5/5] B4860QDS: Add support of 2 stage NAND boot loader Prabhakar Kushwaha
2013-09-17 21:58 ` Rommel Custodio
2013-09-18 11:15 ` Prabhakar Kushwaha [this message]
2013-09-19 23:21 ` Rommel Custodio
2013-09-20 3:51 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52398B66.1070902@freescale.com \
--to=prabhakar@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.