From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6sabresd: Fix the fdt file for the mx6dl version
Date: Wed, 18 Sep 2013 06:48:41 -0700 [thread overview]
Message-ID: <5239AF39.1070008@boundarydevices.com> (raw)
In-Reply-To: <1379469359-19153-1-git-send-email-festevam@gmail.com>
Hi Fabio,
On 09/17/2013 06:55 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We need to load 'imx6dl-sabresd.dtb' in the mx6dl version.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx6sabresd.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
> index a3dd74a..3229bc7 100644
> --- a/include/configs/mx6sabresd.h
> +++ b/include/configs/mx6sabresd.h
> @@ -16,7 +16,11 @@
> #define CONFIG_MXC_UART_BASE UART1_BASE
> #define CONFIG_CONSOLE_DEV "ttymxc0"
> #define CONFIG_MMCROOT "/dev/mmcblk1p2"
> +#if defined(CONFIG_MX6Q)
> #define CONFIG_DEFAULT_FDT_FILE "imx6q-sabresd.dtb"
> +#elif defined(CONFIG_MX6DL)
> +#define CONFIG_DEFAULT_FDT_FILE "imx6dl-sabresd.dtb"
> +#endif
> #define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024)
>
> #include "mx6sabre_common.h"
>
As you know, we're loading the kernel using a boot script,
with various flavors for differing locations and environments,
so we've found it easier to pass environment variables for
board and CPU type to the boot script.
https://github.com/boundarydevices/u-boot-imx6/commit/4a4fc304e4fe63cde7b3201f0daab5b1856870e4
This allows the boot script to produce the DTB name as shown
here:
https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript.txt#L72
If/when you move to a single binary for DQ/DL, you won't have
a separate choice as shown above.
Let me know your thoughts on this.
We didn't generate a proper patch for lack of time, but I
think that the small addition of code has merit. We also
may want to discuss the specifics in more detail.
Regards,
Eric
next prev parent reply other threads:[~2013-09-18 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 1:55 [U-Boot] [PATCH] mx6sabresd: Fix the fdt file for the mx6dl version Fabio Estevam
2013-09-18 2:04 ` Otavio Salvador
2013-09-18 13:48 ` Eric Nelson [this message]
2013-09-19 11:57 ` Fabio Estevam
2013-09-19 14:01 ` Eric Nelson
2013-09-20 13:44 ` Stefano Babic
2013-09-20 13:43 ` Stefano Babic
2013-09-20 14:20 ` Eric Nelson
2013-09-20 16:11 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5239AF39.1070008@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.