From: Mark Tinguely <tinguely@sgi.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>, xfsprogs <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix potential memory leak in repare/sb.c
Date: Wed, 18 Sep 2013 11:26:54 -0500 [thread overview]
Message-ID: <5239D44E.2090408@sgi.com> (raw)
In-Reply-To: <1379497242.5874.7.camel@ThinkPad-T5421>
On 09/18/13 04:40, Li Zhong wrote:
> Following Resource leak is reported by coverity:
>
> CID 997011 (#1 of 1): Resource leak (RESOURCE_LEAK)6. leaked_storage:
> Variable "buf" going out of scope leaks the storage it points to.
> 505 return(XR_EOF);
>
> Add a free(buf) to solve it.
>
> Signed-off-by: Li Zhong<zhong@linux.vnet.ibm.com>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-18 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 9:40 [PATCH] xfsprogs: fix potential memory leak in repare/sb.c Li Zhong
2013-09-18 16:26 ` Mark Tinguely [this message]
2013-10-18 16:35 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5239D44E.2090408@sgi.com \
--to=tinguely@sgi.com \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.