From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49173)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1VMYbG-0006C7-Ip
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 03:24:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1VMYb8-0006dv-54
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 03:24:30 -0400
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:45929 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1VMYb7-0006dk-QF
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 03:24:22 -0400
Message-ID: <523AA6A0.1060209@kamp.de>
Date: Thu, 19 Sep 2013 09:24:16 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1378984634-765-1-git-send-email-pbonzini@redhat.com>
	<1378984634-765-9-git-send-email-pbonzini@redhat.com>
	<52388EF5.4030108@weilnetz.de> <52388F81.7030102@redhat.com>
In-Reply-To: <52388F81.7030102@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

On 17.09.2013 19:21, Paolo Bonzini wrote:
> Il 17/09/2013 19:18, Stefan Weil ha scritto:
>> Latest QEMU git is broken on Debian wheezy:
>>
>> block/iscsi.c: In function ‘iscsi_co_get_block_status’:
>> block/iscsi.c:842:5: error: implicit declaration of function
>> ‘iscsi_get_lba_status_task’ [-Werror=implicit-function-declaration]
>> block/iscsi.c:842:5: error: nested extern declaration of
>> ‘iscsi_get_lba_status_task’ [-Werror=nested-externs]
>> block/iscsi.c:845:43: error: comparison between pointer and integer
>> [-Werror]
>> block/iscsi.c:877:18: error: dereferencing pointer to incomplete type
>> block/iscsi.c:879:55: error: dereferencing pointer to incomplete type
>> block/iscsi.c:884:34: error: dereferencing pointer to incomplete type
>> block/iscsi.c:889:14: error: dereferencing pointer to incomplete type
>> block/iscsi.c:889:32: error: ‘SCSI_PROVISIONING_TYPE_DEALLOCATED’
>> undeclared (first use in this function)
>> block/iscsi.c:889:32: note: each undeclared identifier is reported only
>> once for each function it appears in
>> block/iscsi.c:890:14: error: dereferencing pointer to incomplete type
>> block/iscsi.c:890:32: error: ‘SCSI_PROVISIONING_TYPE_ANCHORED’
>> undeclared (first use in this function)
>> cc1: all warnings being treated as errors
>>
>> Debian includes libiscsi-dev 1.4.0 without a libiscsi.pk, so it uses a
>> compile test
>> which thinks that libiscsi is good enough.
>>
>> Did the latest changes raise the requirements for libscsi?
> Looks like.  Can you make a patch that drops the definition of
> iscsi_co_get_block_status if SCSI_PROVISIONING_TYPE_DEALLOCATED is not
> #defined?
>
> Thanks,
>
> Paolo
do we still need this patch? if yes I can sent one shortly.

Peter