From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH net 3/3] slcan: rewrite of slc_bump and slc_encaps Date: Thu, 19 Sep 2013 11:47:57 +0200 Message-ID: <523AC84D.5030305@pengutronix.de> References: <1379093833-4949-1-git-send-email-nautsch2@gmail.com> <1379093833-4949-4-git-send-email-nautsch2@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="98l0NRXL1hAQOiWrNi9Rat0AfWGPhfRhK" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:52521 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903Ab3ISJsF (ORCPT ); Thu, 19 Sep 2013 05:48:05 -0400 In-Reply-To: <1379093833-4949-4-git-send-email-nautsch2@gmail.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Andre Naujoks Cc: davem@davemloft.net, Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --98l0NRXL1hAQOiWrNi9Rat0AfWGPhfRhK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/13/2013 07:37 PM, Andre Naujoks wrote: > The old implementation was heavy on str* functions and sprintf calls. > This version is more manual, but faster. >=20 > Profiling just the printing of a 3 char CAN-id resulted in 60 instructi= ons > for the manual method and over 2000 for the sprintf method. Bear in > mind the profiling was done against libc and not the kernel sprintf. >=20 > Together with this rewrite an issue with sending and receiving of RTR f= rames > has been fixed by Oliver for the cases that the DLC is not zero. >=20 > Signed-off-by: Andre Naujoks > Tested-by: Oliver Hartkopp Acked-by: Marc Kleine-Budde regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --98l0NRXL1hAQOiWrNi9Rat0AfWGPhfRhK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlI6yE0ACgkQjTAFq1RaXHPXqQCdGprMtXxqWRMPy4iZagdkND27 9xcAnRLi+U9khmsQJYwko/kzvkUUpLGg =m1DH -----END PGP SIGNATURE----- --98l0NRXL1hAQOiWrNi9Rat0AfWGPhfRhK--