From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Quentin Armitage <quentin@armitage.org.uk>, linux-kernel@vger.kernel.org
Cc: Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT
Date: Thu, 19 Sep 2013 13:19:56 +0200 [thread overview]
Message-ID: <523ADDDC.7010008@gmail.com> (raw)
In-Reply-To: <1379588429.2484.84.camel@samson1.armitage.org.uk>
On 09/19/13 13:00, Quentin Armitage wrote:
> There appears to be an error in the second address of the second XOR
> engine in the Kirkwood SoC device tree, which is specified as 0xd0b00
> but should be 0x60b00.
>
> For confirmation of address see
> http://www.marvell.com/embedded-processors/kirkwood/assets/FS_88F6180_9x_6281_OpenSource.pdf table 581 page 658.
> Also see definition of XOR1_HIGH_PHYS_BASE in
> arch/arm/mach-kirkwood/include/mach/kirkwood.h
> #define XOR1_HIGH_PHYS_BASE (KIRKWOOD_REGS_PHYS_BASE + 0x60B00)
>
> Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
I double-checked the references, typo and fix are correct.
Reviewed-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> arch/arm/boot/dts/kirkwood.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood.dtsi
> b/arch/arm/boot/dts/kirkwood.dtsi
> index cf7aeaf..63d4066 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -167,7 +167,7 @@
> xor@60900 {
> compatible = "marvell,orion-xor";
> reg = <0x60900 0x100
> - 0xd0B00 0x100>;
> + 0x60B00 0x100>;
> status = "okay";
> clocks = <&gate_clk 16>;
>
> ---
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2013-09-19 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 11:00 [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT Quentin Armitage
2013-09-19 11:19 ` Sebastian Hesselbarth [this message]
2013-09-20 3:14 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523ADDDC.7010008@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin@armitage.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.