All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: ralf@linux-mips.org, steven.hill@imgtec.com, mmarek@suse.cz,
	swarren@nvidia.com, linux-mips@linux-mips.org,
	linux-kbuild@vger.kernel.org, james.hogan@imgtec.com
Subject: Re: [PATCH] MIPS: fix invalid symbolic link file
Date: Thu, 19 Sep 2013 18:21:31 +0400	[thread overview]
Message-ID: <523B086B.3040206@cogentembedded.com> (raw)
In-Reply-To: <1379596148-32520-1-git-send-email-maddy@linux.vnet.ibm.com>

Hello.

On 09/19/2013 05:09 PM, Madhavan Srinivasan wrote:

>     Commit 3b29aa5ba204c created a symlink file in include/dt-bindings.

    Please also specify that commit's summary line in parens.

>     Even though commit diff is fine, symlink is invalid.
>     ls -lb shows a newline character at the end of the filename.

    Don't indent the changelog please.

> lrwxrwxrwx 1 maddy maddy 35 Sep 19 18:11 dt-bindings ->
> ../../../../../include/dt-bindings\n

> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>

WBR, Sergei



      parent reply	other threads:[~2013-09-19 14:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 13:09 [PATCH] MIPS: fix invalid symbolic link file Madhavan Srinivasan
2013-09-19 13:39 ` git issue / " Ralf Baechle
2013-09-19 16:37   ` Junio C Hamano
2013-09-19 16:37     ` Junio C Hamano
2013-09-19 19:49   ` Johannes Sixt
2013-09-19 20:36     ` Stephen Warren
2013-09-19 14:21 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523B086B.3040206@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=james.hogan@imgtec.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mmarek@suse.cz \
    --cc=ralf@linux-mips.org \
    --cc=steven.hill@imgtec.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.