From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86: mark BUG()s and assertion failures as terminal. Date: Thu, 19 Sep 2013 16:44:25 +0100 Message-ID: <523B1BD9.5050801@citrix.com> References: <1379601586-27173-1-git-send-email-tim@xen.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379601586-27173-1-git-send-email-tim@xen.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: keir@xen.org, jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 19/09/2013 15:39, Tim Deegan wrote: > This helps avoid static analysis false-positives, and might lead to > better code density as the compiler knows it doesn't have to restore > spilled state &c. > > Signed-off-by: Tim Deegan > Out of interest, I tried looking at some numbers for this. Using gcc 4.7.2 (Debian Wheezy), .text decreased by 656 bytes and .init.text decreased by 71 bytes. While those are expected, .rodata decreased by 1224 bytes. I am at a loss to explain the decrease in .rodata, but did double check my compiling, and find the decrease still present. Either way, it looks to be a useful improvement. Reviewed-by: Andrew Cooper