From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VMhZT-00044y-2T
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 12:59:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VMhZL-0002Rl-Me
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 12:59:14 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:33751)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VMhZL-0002RR-Fa
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 12:59:07 -0400
Message-ID: <523B2D55.6060008@weilnetz.de>
Date: Thu, 19 Sep 2013 18:59:01 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <523B2BBF.7020801@suse.de>
In-Reply-To: <523B2BBF.7020801@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] block/stream.c -Werror build failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Am 19.09.2013 18:52, schrieb Andreas F=C3=A4rber:
> Hello,
>
> As reported yesterday on IRC, since the last round of pulls I am gettin=
g
> the following warning-treated-as-error:
>
>   CC    block/stream.o
> /home/andreas/QEMU/qemu/block/stream.c: In function =E2=80=98stream_run=
=E2=80=99:
> /home/andreas/QEMU/qemu/block/stream.c:111:14: error: =E2=80=98copy=E2=80=
=99 may be used
> uninitialized in this function [-Werror=3Dmaybe-uninitialized]
> cc1: all warnings being treated as errors
> make: *** [block/stream.o] Fehler 1
>
> $ gcc --version
> gcc (SUSE Linux) 4.7.2 20130108 [gcc-4_7-branch revision 195012]
>
> However I only got this in 1 of 2 repositories I tried. It turns out
> that --enable-debug avoids this build issue.
>
> The stream.c code itself looks okay to me. In the case of ret >=3D 0, c=
opy
> is always assigned, including the goto code path.
> Still, could we initialize the copy variable to false or revert whateve=
r
> change introduced this build regression? (-Wextra?)
>
> Regards,
> Andreas
>

This will be fixed by the next pull request for the block tree.
See also http://patchwork.ozlabs.org/patch/275503/

Regards,
Stefan