Re: [PATCH 2/2] MIPS: BCM47XX: add EARLY_PRINTK_8250 support

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 09/20/2013 01:44 AM, Hauke Mehrtens wrote:

> The BCM47xx SoCs have a 8250 serial compatible console at address
> 0xb8000300 and an other at 0xb8000400. On most devices 0xb8000300 is
> wired to some pins on the board, we should use that.

    I think these are KSEG1 virtual addresses, not physical.

> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>   arch/mips/Kconfig        |    2 ++
>   arch/mips/bcm47xx/prom.c |    1 +
>   2 files changed, 3 insertions(+)

[...]
> diff --git a/arch/mips/bcm47xx/prom.c b/arch/mips/bcm47xx/prom.c
> index 99c3ce2..26f49f8 100644
> --- a/arch/mips/bcm47xx/prom.c
> +++ b/arch/mips/bcm47xx/prom.c
> @@ -97,6 +97,7 @@ static __init void prom_init_mem(void)
>   void __init prom_init(void)
>   {
>   	prom_init_mem();
> +	setup_8250_early_printk_port(CKSEG1ADDR(0xb8000300), 0, 0);

    Applying CKSEG1ADDR() to virtual address is wrong.

WBR, Sergei