From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package: remove the trailing slash sign from the URL address
Date: Fri, 20 Sep 2013 08:23:22 +0200 [thread overview]
Message-ID: <523BE9DA.7080108@trzebnica.net> (raw)
In-Reply-To: <5A95E57D-D33E-4AAF-9D83-8C6ECEBCD0D6@layer-7.net>
Hi Michael,
Thanks for your feedback.
> Hi Arnout and Jerzy,
>
> of course, Arnout is right that the change of the URLs in the _SITE variables is not that relevant.
> My comment was more targeted to all the other URLs for the upstream projects. Which I now see,
> was not part of your original patch submission. Sorry, that I overlooked that.
No problem.
Yes, the subject of my patch submission is removing the trailing slash
from _SITE variables only.
I see now that the title is a little bit misleading.
> But since I thought you overall wanted to have more consistency with all the URLs, I decided
> to quickly analyse what else we do have in our Config.ins:
>
> Apart from the _SITE URLs, we have:
> - 751 packages, where another URL is used to point to the upstream project
> - 465 of these 751 had a trailing slash at the end of the URL
>
> I then tried to analyse, whether there is a need to modify them:
> - 726 were HTTP Urls where the server responded with:
> 535 200 OK
> 132 301 Moved Permanently
> 42 302
> 1 400
> 2 403
> 13 404
> 1 500
> - 71 of the 132 moved URLs had a trailing slash at the end of their new locations.
>
> Used scripts:
> find package/ -name "Config.in" -exec egrep -i " (ht|f)tp://.*$" {} \; >../buildroot-urls.txt
> cat buildroot-urls.txt |xargs -i ./show_response.sh {} >buildroot-checked-urls.txt
> egrep "^HTTP" buildroot-checked-urls.txt |sed -e "s/HTTP\/.\.. \(...\) .*$/\1/g" | sort | uniq -c
>
> show_response.sh just invokes curl.
> #! /bin/bash
> ARG=$*
> echo "Original URL: " $ARG
> echo "Response: "
> curl -I $ARG 2>/dev/null |egrep "^(HTTP/|Location:)"
> echo
>
> I made the input files available at:
>
> http://michaelrommel.com/buildroot-urls.txt
> http://michaelrommel.com/buildroot-checked-urls.txt
> http://michaelrommel.com/buildroot-moved-urls.txt
Interesting...
I think, this information will certainly be useful for the BR upstream
projects
and patches.
Regards,
Jerzy
> to avoid clutter on this list.
>
> Michael.
>
prev parent reply other threads:[~2013-09-20 6:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 15:24 [Buildroot] [PATCH 1/1] package: remove the trailing slash sign from the URL address Jerzy Grzegorek
2013-09-18 15:34 ` Thomas De Schampheleire
2013-09-18 15:44 ` Jerzy Grzegorek
2013-09-18 17:56 ` Michael Rommel
2013-09-18 20:48 ` Jerzy Grzegorek
2013-09-18 22:31 ` Michael Rommel
2013-09-18 16:51 ` Thomas Petazzoni
2013-09-19 7:06 ` Thomas De Schampheleire
2013-09-19 19:43 ` Thomas Petazzoni
2013-09-18 22:48 ` Arnout Vandecappelle
2013-09-19 13:56 ` Michael Rommel
2013-09-20 6:23 ` Jerzy Grzegorek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523BE9DA.7080108@trzebnica.net \
--to=jerzy.grzegorek@trzebnica.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.