From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Date: Fri, 20 Sep 2013 07:24:30 +0000 Subject: Re: [PATCH 01/15] video: atmel_lcdfb: Remove redundant dev_set_drvdata Message-Id: <523BF82E.8000505@atmel.com> List-Id: References: <1379658744-17113-2-git-send-email-sachin.kamat@linaro.org> In-Reply-To: <1379658744-17113-2-git-send-email-sachin.kamat@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-fbdev@vger.kernel.org On 20/09/2013 08:32, Sachin Kamat : > Driver core sets driver data to NULL upon failure or remove. > > Signed-off-by: Sachin Kamat > Cc: Nicolas Ferre Acked-by: Nicolas Ferre > --- > drivers/video/atmel_lcdfb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c > index 34e934d..70052e7 100644 > --- a/drivers/video/atmel_lcdfb.c > +++ b/drivers/video/atmel_lcdfb.c > @@ -1318,7 +1318,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) > return 0; > > reset_drvdata: > - dev_set_drvdata(dev, NULL); > fb_dealloc_cmap(&info->cmap); > unregister_irqs: > cancel_work_sync(&sinfo->task); > @@ -1379,7 +1378,6 @@ static int __exit atmel_lcdfb_remove(struct platform_device *pdev) > atmel_lcdfb_free_video_memory(sinfo); > } > > - dev_set_drvdata(dev, NULL); > framebuffer_release(info); > > return 0; > -- Nicolas Ferre