From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH RFC v12 06/21] pvh: Introduce PVH guest type
Date: Fri, 20 Sep 2013 11:01:04 +0100
Message-ID: <523C1CE0.2090803@eu.citrix.com>
References: <1379089521-25720-1-git-send-email-george.dunlap@eu.citrix.com>
	<1379089521-25720-7-git-send-email-george.dunlap@eu.citrix.com>
	<5239D08102000078000F4675@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@eu.citrix.com>) id 1VMxWS-0004ZD-JY
	for xen-devel@lists.xenproject.org; Fri, 20 Sep 2013 10:01:12 +0000
In-Reply-To: <5239D08102000078000F4675@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 18/09/13 15:10, Jan Beulich wrote:
>>>> On 13.09.13 at 18:25, George Dunlap <george.dunlap@eu.citrix.com> wrote:
>> Introduce new PVH guest type, flags to create it, and ways to identify it.
>>
>> To begin with, it will inherit functionality marked hvm_container.
>>
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> with one minor comment:
>
>> --- a/xen/common/domctl.c
>> +++ b/xen/common/domctl.c
>> @@ -187,6 +187,8 @@ void getdomaininfo(struct domain *d, struct
>> xen_domctl_getdomaininfo *info)
>>   
>>       if ( is_hvm_domain(d) )
>>           info->flags |= XEN_DOMINF_hvm_guest;
>> +    else if ( is_pvh_domain(d) )
>> +        info->flags |= XEN_DOMINF_pvh_guest;
> I'd prefer constructs like this to be done as a switch statement.

Hmm, the resulting boilerplate takes up 11 lines rather than 4, but I 
guess that's OK with me...

Thanks,
  -George