Re: [Qemu-devel] [PATCH 02/17] qapi-types/visit.py: Inheritance for structs

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On 09/20/2013 05:54 AM, Kevin Wolf wrote:
> This introduces a new 'base' key for struct definitions that refers to
> another struct type. On the JSON level, the fields of the base type are
> included directly into the same namespace as the fields of the defined
> type, like with unions. On the C level, a pointer to a struct of the
> base type is included.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  docs/qapi-code-gen.txt | 17 +++++++++++++++++
>  scripts/qapi-types.py  |  4 ++++
>  scripts/qapi-visit.py  | 18 ++++++++++++++++--
>  3 files changed, 37 insertions(+), 2 deletions(-)

> +
> +An example BlockdevOptionsGenericCOWFormat object on the wire could use
> +both fields like this:
> +
> + { "file": "/some/place/my-image"

Missing a comma.

> +   "backing": "/some/place/my-backing-file" } }

Mismatch - too many }.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]