From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2Ey-0007S3-3I for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:03:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2Et-0006Cs-61 for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:03:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2Es-0006Cn-Th for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:03:23 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8KF3Mok004247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Sep 2013 11:03:22 -0400 Message-ID: <523C63B9.5040707@redhat.com> Date: Fri, 20 Sep 2013 09:03:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1379678070-14346-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DpU5E8CdcdBnH4vLNODCT72dm6SHIfCOP" Subject: Re: [Qemu-devel] [PATCH 03/17] blockdev: Introduce DriveInfo.enable_auto_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DpU5E8CdcdBnH4vLNODCT72dm6SHIfCOP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/20/2013 05:54 AM, Kevin Wolf wrote: > BlockDriverStates shouldn't be affected by an unplugged guest device, > except if created with the legacy -drive command line option or the > drive_add HMP command. >=20 > Make the automatic deletion as well as cancelling of jobs conditional o= n > an enable_auto_del boolean that is only set in drive_init(). >=20 > Signed-off-by: Kevin Wolf > --- > +++ b/include/sysemu/blockdev.h > @@ -37,6 +37,7 @@ struct DriveInfo { > int bus; > int unit; > int auto_del; /* see blockdev_mark_auto_del() */ > + bool enable_auto_del; /* Only for legacy drive_init() */ auto_del is 0-initialized, and only ever assigned to 1. Should it also be bool? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DpU5E8CdcdBnH4vLNODCT72dm6SHIfCOP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSPGO5AAoJEKeha0olJ0Nqt2QH/2WATQkU4MSIFAMPMo1f25LL SPbEBCp1PpOZ1uj7rQYvZ6cPmdZ/fKRpTUZKbB33wxF4yZMacmeyz/5Zeu7c9ATw t/6LyqtgHPVSre+Km3ODKj8JFuphx9eo3mMmMtYVJ2qDl7pg1lgP2honC7nV2Cgy 1DI3lG5kktYy584yVGRkFjXpM1w0xkQWCbG7x4zbKQS7cUI+GHAiiFsoFZS8svtA TDkmUAEr9qkpsA7pVLOyO+0TYkgd+64G6Qz+0FGWUj/Qfd9IekwH+p8ZnvlypGF4 q3tz8+C+r8z+bz7oi7Ra9SyE20m7fDUbeptXbMvw49VuMbiIdzGvK/UiyKi5yFQ= =TujK -----END PGP SIGNATURE----- --DpU5E8CdcdBnH4vLNODCT72dm6SHIfCOP--