From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, asias@redhat.com, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents
Date: Fri, 20 Sep 2013 17:04:33 +0200 [thread overview]
Message-ID: <523C6401.3020509@redhat.com> (raw)
In-Reply-To: <20130919113102.GG22814@stefanha-thinkpad.redhat.com>
Il 19/09/2013 13:31, Stefan Hajnoczi ha scritto:
>> > We use the extent size as cluster size for flat extents (where no L1/L2
>> > table is allocated so it's safe).
> Why is the extent size passed as the cluster size parameter?
I think it's so that the flat extent doesn't take up too many cache entries.
Paolo
> The cleaner fix would be to stop passing it as cluster size :).
next prev parent reply other threads:[~2013-09-20 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 11:14 [Qemu-devel] [PATCH 0/2] block: two fixes for image opening Fam Zheng
2013-09-18 11:14 ` [Qemu-devel] [PATCH 1/2] block: don't lose data from last incomplete sector Fam Zheng
2013-09-20 14:41 ` Stefan Hajnoczi
2013-09-18 11:14 ` [Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents Fam Zheng
2013-09-19 11:31 ` Stefan Hajnoczi
2013-09-20 15:04 ` Paolo Bonzini [this message]
2013-09-22 0:53 ` Fam Zheng
2013-09-19 11:31 ` [Qemu-devel] [PATCH 0/2] block: two fixes for image opening Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C6401.3020509@redhat.com \
--to=pbonzini@redhat.com \
--cc=asias@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.