From: Jiri Slaby <jslaby@suse.cz>
To: David Miller <davem@davemloft.net>
Cc: ben@decadent.org.uk, akpm@linux-foundation.org, jeffm@suse.com,
netdev@vger.kernel.org, isdn4linux@koppen.de,
isdn@linux-pingi.de, sergei.shtylyov@cogentembedded.com
Subject: Re: [patch 2/4] mISDN: add support for group membership check
Date: Fri, 20 Sep 2013 18:30:06 +0200 [thread overview]
Message-ID: <523C780E.5050201@suse.cz> (raw)
In-Reply-To: <20130920.122142.1032350399957506112.davem@davemloft.net>
On 09/20/2013 06:21 PM, David Miller wrote:
> From: Jiri Slaby <jslaby@suse.cz>
> Date: Fri, 20 Sep 2013 18:18:02 +0200
>
>> Ok, let's leave the hole in there then.
>
> Jiri, don't turn this on me.
>
> The issue is not whether something needs to be fixed or not, I never
> said "don't fix this" and therefore I'd like to ask politely that you
> not make it seem like I have.
>
> Rather, I'm saying that the implementation is terrible, sets a bad
> precendence for fixing similar problems, and therefore not is in
> a state where we can apply it.
>
> So, I'm not saying "don't fix this", I'm saying "fix it properly."
Yeah, I understand your point and agree, that the parameter is ugly as
hell. But investing any more time in ISDN is not worth it, I think.
Look, I sent the patch a couple times to the ISDN maintainers and they
didn't even bother to reply. And I am not familiar with the code and do
not want to spend more time than putting there a single check, sorry.
Hence, if there is anybody from the ISDN fellows to take care of that,
nice. If not, we will just live with this patch locally some more years
and drop it when the ISDN subsystem is dropped from the kernel, if
dropped at all.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2013-09-20 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 21:52 [patch 2/4] mISDN: add support for group membership check akpm
2013-09-14 0:00 ` David Miller
2013-09-14 23:28 ` Ben Hutchings
2013-09-20 13:44 ` Jiri Slaby
2013-09-20 15:56 ` David Miller
2013-09-20 16:14 ` Jiri Slaby
2013-09-20 16:15 ` David Miller
2013-09-20 16:18 ` Jiri Slaby
2013-09-20 16:21 ` David Miller
2013-09-20 16:30 ` Jiri Slaby [this message]
2013-09-21 15:36 ` Karsten Keil
2013-09-20 16:30 ` Ben Hutchings
2013-09-20 17:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C780E.5050201@suse.cz \
--to=jslaby@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=isdn4linux@koppen.de \
--cc=isdn@linux-pingi.de \
--cc=jeffm@suse.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.