From: Damien Millescamps <damien.millescamps@6wind.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, berrange@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v3] ivshmem: allow the sharing of hugepages
Date: Fri, 20 Sep 2013 20:16:11 +0200 [thread overview]
Message-ID: <523C90EB.5050005@6wind.com> (raw)
In-Reply-To: <523C7C91.4040501@msgid.tls.msk.ru>
On 09/20/2013 06:49 PM, Michael Tokarev wrote:
> Can you please send a v4 with the above changes? Hopefully you agree
> with them. Overall, I like this new version too.
Ok, I'll do that ASAP. I'll try to find a better wording for the error
messages.
At first I tried to modify the code as little as possible to be eligible
for qemu-trivial, but clearly I am in favor of adding %m or perror when
a syscall fails.
BTW, there are some other issues in the ivshmem code, like the maximum
size is not enforced (256M in 32b and 4G in 64b) but I am currently
investigating a bug in the linux kernel when the size is > 256M (this
leads to really weird behavior when coupled with VT-d), so I'll wait to
be sure it is really in the kernel and not QEMU related before
submitting this part.
Thanks,
--
Damien
WARNING: multiple messages have this Message-ID (diff)
From: Damien Millescamps <damien.millescamps@6wind.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] ivshmem: allow the sharing of hugepages
Date: Fri, 20 Sep 2013 20:16:11 +0200 [thread overview]
Message-ID: <523C90EB.5050005@6wind.com> (raw)
In-Reply-To: <523C7C91.4040501@msgid.tls.msk.ru>
On 09/20/2013 06:49 PM, Michael Tokarev wrote:
> Can you please send a v4 with the above changes? Hopefully you agree
> with them. Overall, I like this new version too.
Ok, I'll do that ASAP. I'll try to find a better wording for the error
messages.
At first I tried to modify the code as little as possible to be eligible
for qemu-trivial, but clearly I am in favor of adding %m or perror when
a syscall fails.
BTW, there are some other issues in the ivshmem code, like the maximum
size is not enforced (256M in 32b and 4G in 64b) but I am currently
investigating a bug in the linux kernel when the size is > 256M (this
leads to really weird behavior when coupled with VT-d), so I'll wait to
be sure it is really in the kernel and not QEMU related before
submitting this part.
Thanks,
--
Damien
next prev parent reply other threads:[~2013-09-20 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 13:46 [Qemu-trivial] [PATCH v3] ivshmem: allow the sharing of hugepages Damien Millescamps
2013-09-16 13:46 ` [Qemu-devel] " Damien Millescamps
2013-09-20 16:49 ` [Qemu-trivial] " Michael Tokarev
2013-09-20 16:49 ` [Qemu-devel] " Michael Tokarev
2013-09-20 18:16 ` Damien Millescamps [this message]
2013-09-20 18:16 ` Damien Millescamps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C90EB.5050005@6wind.com \
--to=damien.millescamps@6wind.com \
--cc=berrange@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.