From: "Ward, David - 0663 - MITLL" <david.ward@ll.mit.edu>
To: David Miller <davem@davemloft.net>
Cc: "noel@burton-krahn.com" <noel@burton-krahn.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"joe@perches.com" <joe@perches.com>
Subject: Re: [PATCH 1/1] mrp: add periodictimer to allow retries when packets get lost
Date: Fri, 20 Sep 2013 21:32:13 -0400 [thread overview]
Message-ID: <523CF71D.3090002@ll.mit.edu> (raw)
In-Reply-To: <20130920.145903.1454447110808820874.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
Noel, thanks for your patch. This timer was apparently not in the GARP
standard but added in the MRP standard and I missed it. Looks good to me.
Acked-by: David Ward <david.ward@ll.mit.edu>
On 09/20/2013 02:59 PM, David Miller wrote:
> Re: [PATCH 1/1] mrp: add periodictimer to allow retries when packets
> get lost
>
> From: Noel Burton-Krahn <noel@burton-krahn.com>
> Date: Wed, 18 Sep 2013 12:24:40 -0700
>
> > MRP doesn't implement the periodictimer in 802.1Q, so it never retries
> > if packets get lost. I ran into this problem when MRP sent a MVRP
> > JoinIn before the interface was fully up. The JoinIn was lost, MRP
> > didn't retry, and MVRP registration failed.
> >
> > Tested against Juniper QFabric switches
> >
> > Signed-off-by: Noel Burton-Krahn <noel@burton-krahn.com>
>
> David W., please review this patch.
>
> Thanks.
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4571 bytes --]
next prev parent reply other threads:[~2013-09-21 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 17:09 [PATCH] mrp: add periodictimer to retry lost packets Noel Burton-Krahn
2013-09-18 17:54 ` David Miller
2013-09-18 18:20 ` Joe Perches
2013-09-18 19:24 ` [PATCH 1/1] mrp: add periodictimer to allow retries when packets get lost Noel Burton-Krahn
2013-09-20 18:59 ` David Miller
2013-09-21 1:32 ` Ward, David - 0663 - MITLL [this message]
2013-09-23 20:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523CF71D.3090002@ll.mit.edu \
--to=david.ward@ll.mit.edu \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=noel@burton-krahn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.