From: Jan Kiszka <jan.kiszka@web.de>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai] [Xenomai-git] Jan Kiszka : cobalt/posix/sem: Fix locking imbalances in cobalt_sem_open
Date: Sat, 21 Sep 2013 11:17:57 +0200 [thread overview]
Message-ID: <523D6445.901@web.de> (raw)
In-Reply-To: <523D594F.1050605@xenomai.org>
On 2013-09-21 10:31, Philippe Gerum wrote:
> On 09/20/2013 08:42 PM, git repository hosting wrote:
>> Module: xenomai-jki
>> Branch: for-forge
>> Commit: 8775720ae828d1e1be076f91b93a3eeac1b7ed90
>> URL:
>> http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=8775720ae828d1e1be076f91b93a3eeac1b7ed90
>>
>>
>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>> Date: Fri Sep 20 20:39:18 2013 +0200
>>
>> cobalt/posix/sem: Fix locking imbalances in cobalt_sem_open
>>
>> We hold cobalt_assoc_lock, not nklock.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>
> This fix should be backported to 2.6.
I don't find this pattern in 2.6. There we seem to use only nklock.
Jan
>
>> ---
>>
>> kernel/cobalt/posix/sem.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/cobalt/posix/sem.c b/kernel/cobalt/posix/sem.c
>> index 076f2d2..60906fd 100644
>> --- a/kernel/cobalt/posix/sem.c
>> +++ b/kernel/cobalt/posix/sem.c
>> @@ -916,7 +916,7 @@ int cobalt_sem_open(unsigned long __user *u_addr,
>> if (assoc) {
>> usm = container_of(assoc, struct cobalt_usem, assoc);
>> ++usm->refcnt;
>> - xnlock_put_irqrestore(&nklock, s);
>> + xnlock_put_irqrestore(&cobalt_assoc_lock, s);
>> goto got_usm;
>> }
>>
>> @@ -936,7 +936,7 @@ int cobalt_sem_open(unsigned long __user *u_addr,
>> assoc = cobalt_assoc_lookup(&cc->usems, (u_long)sm->sem);
>> if (assoc) {
>> container_of(assoc, struct cobalt_usem, assoc)->refcnt++;
>> - xnlock_put_irqrestore(&nklock, s);
>> + xnlock_put_irqrestore(&cobalt_assoc_lock, s);
>> xnfree(usm);
>> usm = container_of(assoc, struct cobalt_usem, assoc);
>> goto got_usm;
>>
>>
>> _______________________________________________
>> Xenomai-git mailing list
>> Xenomai-git@xenomai.org
>> http://www.xenomai.org/mailman/listinfo/xenomai-git
>>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20130921/bac4704f/attachment.pgp>
next prev parent reply other threads:[~2013-09-21 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VN5el-0002Ct-8K@xenomai.org>
2013-09-21 8:31 ` [Xenomai] [Xenomai-git] Jan Kiszka : cobalt/posix/sem: Fix locking imbalances in cobalt_sem_open Philippe Gerum
2013-09-21 9:17 ` Jan Kiszka [this message]
2013-09-21 9:56 ` Philippe Gerum
2013-09-21 10:00 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523D6445.901@web.de \
--to=jan.kiszka@web.de \
--cc=rpm@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.