All of lore.kernel.org
 help / color / mirror / Atom feed
From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return().
Date: Sat, 21 Sep 2013 19:06:47 +0800	[thread overview]
Message-ID: <523D7DC7.8030603@asianux.com> (raw)

The return value of atomic64_add_return() is u64 which never less than
zero, so need type cast 's64' for comparing in atomic64_add_negative().

The related error: (allmodconfig for S5PV210, with "EXTRA_CFLAGS=-W"):

  kernel/events/core.c:5404:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/arm/include/asm/atomic.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index da1c77d..8cf005d 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -475,7 +475,7 @@ static inline int atomic64_add_unless(atomic64_t *v, u64 a, u64 u)
 	return ret;
 }
 
-#define atomic64_add_negative(a, v)	(atomic64_add_return((a), (v)) < 0)
+#define atomic64_add_negative(a, v)	((s64)atomic64_add_return((a), (v)) < 0)
 #define atomic64_inc(v)			atomic64_add(1LL, (v))
 #define atomic64_inc_return(v)		atomic64_add_return(1LL, (v))
 #define atomic64_inc_and_test(v)	(atomic64_inc_return(v) == 0)
-- 
1.7.7.6

             reply	other threads:[~2013-09-21 11:06 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21 11:06 Chen Gang [this message]
2013-09-24  9:30 ` [PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return() Will Deacon
2013-09-24 10:27   ` Russell King - ARM Linux
2013-09-24 10:37     ` Chen Gang
2013-09-24 10:30   ` Chen Gang
2013-09-25  2:25   ` [PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Chen Gang
2013-09-25 16:07     ` Will Deacon
2013-09-26  2:00       ` Chen Gang
2013-09-26 10:04         ` Will Deacon
2013-09-26 11:03           ` Chen Gang
2013-09-27 11:06             ` Will Deacon
2013-09-27 11:36               ` Chen Gang
2013-09-29  3:43               ` [PATCH 0/2] ARM: include: asm: change functions' and variables' types in atomic.h Chen Gang
2013-09-29  3:43                 ` [PATCH 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Chen Gang
2013-09-29  3:52                   ` [PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables " Chen Gang
2013-09-30 16:11                     ` Will Deacon
2013-10-01  2:05                       ` Chen Gang
2013-10-01  9:01                         ` Will Deacon
2013-10-01 12:03                           ` Chen Gang
2013-10-02 10:41                             ` Will Deacon
2013-10-02 15:19                               ` Chen Gang
2013-10-03 10:05                                 ` Chen Gang
2013-10-03 16:32                                   ` Will Deacon
2013-10-04  9:51                                     ` Chen Gang
2013-10-04 15:37                                       ` Will Deacon
2013-10-04 15:42                                         ` Will Deacon
2013-10-04 23:55                                           ` Chen Gang
2013-10-05  0:11                                             ` Chen Gang
2013-10-08  4:10                                               ` Chen Gang
2013-10-08 10:34                                                 ` Will Deacon
2013-10-08 10:56                                                   ` [PATCH v2 0/2] ARM: include: asm: change functions' and variables' types in atomic.h Chen Gang
2013-10-08 10:57                                                     ` [PATCH v2 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Chen Gang
2013-10-08 10:59                                                       ` [PATCH v2 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for 'oldval' in atomic_cmpxchg() Chen Gang
2013-10-09 10:48                                                         ` Will Deacon
2013-10-10  0:56                                                           ` Chen Gang
2013-10-09 10:46                                                       ` [PATCH v2 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Will Deacon
2013-10-08 11:00                                                   ` [PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables " Chen Gang
2013-10-08 10:33                                             ` Will Deacon
2013-10-08 11:29                                               ` Chen Gang
2013-10-08 17:49                                                 ` Will Deacon
2013-10-09  0:18                                                   ` Chen Gang
2013-10-09  1:22                                                     ` Chen Gang
2013-09-30 16:07                   ` [PATCH 1/2] ARM: include: asm: use 'long long' instead of 'u64' " Will Deacon
2013-10-01  2:09                     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523D7DC7.8030603@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.