All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 04/24] iio:ad7298: Use iio_push_to_buffers_with_timestamp()
Date: Sat, 21 Sep 2013 13:11:01 +0100	[thread overview]
Message-ID: <523D8CD5.7060007@kernel.org> (raw)
In-Reply-To: <1379595601-26448-4-git-send-email-lars@metafoo.de>

On 09/19/13 13:59, Lars-Peter Clausen wrote:
> Makes the code a bit shorter and less ugly.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git

> ---
>  drivers/iio/adc/ad7298.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c
> index 0812556..2a3b65c 100644
> --- a/drivers/iio/adc/ad7298.c
> +++ b/drivers/iio/adc/ad7298.c
> @@ -159,20 +159,14 @@ static irqreturn_t ad7298_trigger_handler(int irq, void *p)
>  	struct iio_poll_func *pf = p;
>  	struct iio_dev *indio_dev = pf->indio_dev;
>  	struct ad7298_state *st = iio_priv(indio_dev);
> -	s64 time_ns = 0;
>  	int b_sent;
>  
>  	b_sent = spi_sync(st->spi, &st->ring_msg);
>  	if (b_sent)
>  		goto done;
>  
> -	if (indio_dev->scan_timestamp) {
> -		time_ns = iio_get_time_ns();
> -		memcpy((u8 *)st->rx_buf + indio_dev->scan_bytes - sizeof(s64),
> -			&time_ns, sizeof(time_ns));
> -	}
> -
> -	iio_push_to_buffers(indio_dev, st->rx_buf);
> +	iio_push_to_buffers_with_timestamp(indio_dev, st->rx_buf,
> +		iio_get_time_ns());
>  
>  done:
>  	iio_trigger_notify_done(indio_dev->trig);
> 

  reply	other threads:[~2013-09-21 11:10 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 12:59 [PATCH 01/24] iio: Add iio_push_buffers_with_timestamp() helper Lars-Peter Clausen
2013-09-19 12:59 ` [PATCH 02/24] iio:bma180: Use iio_push_buffers_with_timestamp() Lars-Peter Clausen
2013-09-21 12:08   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 03/24] iio:ad7266: Use iio_push_to_buffers_with_timestamp() Lars-Peter Clausen
2013-09-21 12:10   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 04/24] iio:ad7298: " Lars-Peter Clausen
2013-09-21 12:11   ` Jonathan Cameron [this message]
2013-09-19 12:59 ` [PATCH 05/24] iio:ad7476: " Lars-Peter Clausen
2013-09-21 12:11   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 06/24] iio:ad7887: " Lars-Peter Clausen
2013-09-21 12:11   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 07/24] iio:ad7923: " Lars-Peter Clausen
2013-09-21 12:12   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 08/24] iio:ad_sigma_delta: " Lars-Peter Clausen
2013-09-21 12:12   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 09/24] iio:at91_adc: " Lars-Peter Clausen
2013-09-21 12:12   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 10/24] iio:max1363: " Lars-Peter Clausen
2013-09-21 12:13   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 11/24] iio:st_sensors: " Lars-Peter Clausen
2013-09-21 12:13   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 12/24] iio:itg3200: " Lars-Peter Clausen
2013-09-21 12:14   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 13/24] iio:adis16400: " Lars-Peter Clausen
2013-09-21 12:15   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 14/24] iio:adis_lib: " Lars-Peter Clausen
2013-09-21 12:15   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 15/24] iio:mpu6050: " Lars-Peter Clausen
2013-09-21 12:16   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 16/24] iio:adjd_s311: " Lars-Peter Clausen
2013-09-21 12:16   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 17/24] iio:tcs3472: " Lars-Peter Clausen
2013-09-21 12:17   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 18/24] iio:gp2ap020a00f: " Lars-Peter Clausen
2013-09-21 12:17   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 19/24] staging:iio:lis3l02dq: " Lars-Peter Clausen
2013-09-21 12:18   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 20/24] staging:iio:ad7606: " Lars-Peter Clausen
2013-09-21 12:18   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 21/24] staging:iio:ad799x: " Lars-Peter Clausen
2013-09-21 12:19   ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 22/24] staging:iio:mxs-lradc: " Lars-Peter Clausen
2013-09-21 12:19   ` Jonathan Cameron
2013-09-19 13:00 ` [PATCH 23/24] staging:iio:dummy: " Lars-Peter Clausen
2013-09-21 12:19   ` Jonathan Cameron
2013-09-19 13:00 ` [PATCH 24/24] staging:iio:ade7758: " Lars-Peter Clausen
2013-09-21 12:20   ` Jonathan Cameron
2013-09-21 12:08 ` [PATCH 01/24] iio: Add iio_push_buffers_with_timestamp() helper Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523D8CD5.7060007@kernel.org \
    --to=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.