From: Johannes Sixt <j6t@kdbg.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH v2] build: add default configuration
Date: Sat, 21 Sep 2013 20:58:07 +0200 [thread overview]
Message-ID: <523DEC3F.9080807@kdbg.org> (raw)
In-Reply-To: <1379764036-3782-1-git-send-email-felipe.contreras@gmail.com>
Am 21.09.2013 13:47, schrieb Felipe Contreras:
> diff --git a/Makefile b/Makefile
> index 3588ca1..18081bf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1010,7 +1010,7 @@ ifndef sysconfdir
> ifeq ($(prefix),/usr)
> sysconfdir = /etc
> else
> -sysconfdir = etc
> +sysconfdir = $(prefix)/etc
Not good: There is a reason why this is a relative path. Please dig the
history, it's pretty clear.
-- Hannes
next prev parent reply other threads:[~2013-09-21 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 11:47 [PATCH v2] build: add default configuration Felipe Contreras
2013-09-21 17:50 ` David Aguilar
2013-09-21 18:58 ` Johannes Sixt [this message]
2013-09-21 19:02 ` Felipe Contreras
2013-09-22 5:19 ` David Aguilar
2013-09-22 5:34 ` Felipe Contreras
2013-09-22 8:52 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523DEC3F.9080807@kdbg.org \
--to=j6t@kdbg.org \
--cc=davvid@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.