Re: [PATCH] ata_piix: minor typo fixes and threading fix

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 22-09-2013 18:44, Sergei Shtylyov wrote:

>> Hi,

>> The following patch fixes a printk() call, which was originally used with
>> pr_cont, which will however fail. Fixed that with setting up a buffer to save
>> data to that first, and then printk() it. The patch also
>> fixes some minor typos and a comment, so that it better reflects the
>> documentation of ICH*.

>     Wrap your changelog lines at 80 columns (preferably less).

>> Regards,
>> Levente Kurusa

>     The patch changelog is not a place for greetings and regards.

>> Signed-off-by: Levente Kurusa <levex@linux.com>
>> ---
>> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
>> index 93cb092..b7bf3df 100644
>> --- a/drivers/ata/ata_piix.c
>> +++ b/drivers/ata/ata_piix.c
[...]
>> @@ -1368,34 +1368,53 @@ static const int *piix_init_sata_map(struct pci_dev
>> *pdev,
>>       pci_read_config_byte(pdev, ICH5_PMR, &map_value);
>>
>>       map = map_db->map[map_value & map_db->mask];
>> -
>> -    dev_info(&pdev->dev, "MAP [");
>> +    char* mapdata[4];

>     Don't mix declarations and data.

    Oops, I meant to type "code" instead of "data", of course.

WBR, Sergei