From: Michael Tokarev <mjt@tls.msk.ru>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@gmail.com
Subject: Re: [Qemu-devel] [PATCH 1/2] tests: build the helper program in main build process
Date: Mon, 23 Sep 2013 00:36:36 +0400 [thread overview]
Message-ID: <523F54D4.4030103@msgid.tls.msk.ru> (raw)
In-Reply-To: <1379838614-23890-2-git-send-email-xiawenc@linux.vnet.ibm.com>
22.09.2013 12:30, Wenchao Xia пишет:
> This is a quick way to update helper program when qemu main code
> is changed or built, instead of adding new Makefile under test/qemu-iotest.
Why?
[]
> +# Build the help program automatically
> +
> +all: $(QEMU_IOTESTS_HELPERS-y)
>
This appears to be somewhat awkward way (to do something which I
clearly don't see).
First, it is not clear why this iotest helper should be built
by default when we hasn't been asked to perform the tests.
Second, it apparently does not achieve the (unknown) goal
anyway. At least the patch does not do what the commit
coment says. Commit says that the helper gets updated when
qemu main code is changed or built (which is main code?).
But when I build, say, subdir-x86_64-softmmu, which is
definitely some "main" code, the helper isn't being built...
Count me confused... :)
/mjt
next prev parent reply other threads:[~2013-09-22 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 8:30 [Qemu-devel] [PATCH 0/2] build: trivial patches for test Wenchao Xia
2013-09-22 8:30 ` [Qemu-devel] [PATCH 1/2] tests: build the helper program in main build process Wenchao Xia
2013-09-22 20:36 ` Michael Tokarev [this message]
2013-09-22 23:22 ` Wenchao Xia
2013-09-24 3:20 ` Wenchao Xia
2013-09-22 8:30 ` [Qemu-devel] [PATCH 2/2] build: add command check-clean Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523F54D4.4030103@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.