All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Durgin <josh.durgin@inktank.com>
To: Andrey Korolyov <andrey@xdel.ru>,
	ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: Hiding auth key string for the qemu process
Date: Mon, 23 Sep 2013 01:23:29 -0700	[thread overview]
Message-ID: <523FFA81.8000101@inktank.com> (raw)
In-Reply-To: <CABYiri_WXi-CCtJBJZSsy7t8MsX6kVdq=OHKiRmS+kDhekhyiw@mail.gmail.com>

On 09/22/2013 12:54 PM, Andrey Korolyov wrote:
> Hello,
>
> Since it was a long time from enabling cephx by default and we may
> think that everyone using it, is seems worthy to introduce bits of
> code hiding the key from cmdline. First applicable place for such
> improvement is most-likely OpenStack envs with their sparse security
> and usage of admin key as default one.

I doubt most people are using the admin keyring, since the docs for
openstack show different users for images and volumes, but it's worth
tackling this again.

Basically this requires changing QEMU and making libvirt use the new 
interface when it's available. There was some discussion [1] and an rfc
[2] a while back regarding this. The same approach of modifying the
bdrv_set_key command should work, but IIRC there was a complication
that could be corrected. QEMU attempted to read the device size before
pausing the vm and waiting for the password (cephx secret in this
case), but with rbd the size isn't available until after the driver has
the secret with which to connect to the cluster. If the vm were paused
before the size of the disk was read, the patches would be simpler.

It's probably not too hard to rework those patches if anyone's
interested in picking them up.

Josh

[1] http://www.redhat.com/archives/libvir-list/2011-October/msg00998.html
[2] http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01337.html

      reply	other threads:[~2013-09-23  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-22 19:54 Hiding auth key string for the qemu process Andrey Korolyov
2013-09-23  8:23 ` Josh Durgin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523FFA81.8000101@inktank.com \
    --to=josh.durgin@inktank.com \
    --cc=andrey@xdel.ru \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.