[Openvpn-devel] [M] Change in openvpn[release/2.6]: win: replace wmic invocation with powershell

["cron2 (Code Review)" <gerrit@...515...>]

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

Attention is currently required from: flichtenheld, plaisthos, stipa.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1183?usp=email )

Change subject: win: replace wmic invocation with powershell
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Patchset:

PS2:
I have tested this on win11 24h2 / arm64.

With 2.6.14 "standard" and DCO, setting DNS domain does not work (no useful error log findable though, see github #842).  Stopping the service, replacing openvpnsrv.exe with one from Lev's repo, and restarting, makes DNS domain work.

Did not test running openvpn.exe in privileged mode.

For a +2 someone who understands this better should do an actual review ;-)



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1183?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Iff2f4ea677fe2d88659d7814dab0f792f5004fb3
Gerrit-Change-Number: 1183
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipakov@...277...>
Gerrit-Reviewer: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2641...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...1227...>
Gerrit-Attention: flichtenheld <frank@...2641...>
Gerrit-Attention: stipa <lstipakov@...277...>
Gerrit-Comment-Date: Sun, 14 Sep 2025 19:54:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[-- Attachment #2: Type: text/html, Size: 3162 bytes --]