From: Arun Joseph <arunjoseph@ti.com>
To: Matthias Kaehlcke <matthias.list@kaehlcke.net>,
Jonathan Cameron <jic23@kernel.org>,
Jonathan Cameron <jic23@cam.ac.uk>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Felipe Balbi <balbi@ti.com>,
Pantelis Antoniou <panto@antoniou-consulting.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Nori, Sekhar" <nsekhar@ti.com>
Subject: Re: [PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into account for conversion timeout
Date: Mon, 23 Sep 2013 14:27:32 +0530 [thread overview]
Message-ID: <5240027C.9040804@ti.com> (raw)
In-Reply-To: <20130922175145.GB27515@raspi>
On Sunday 22 September 2013 11:21 PM, Matthias Kaehlcke wrote:
> Hi,
>
> El Sat, Sep 21, 2013 at 01:25:42PM +0100 Jonathan Cameron ha dit:
>
>> On 09/16/13 22:17, Matthias Kaehlcke wrote:
>>> The calculation of the old conversion timeout value was based on the number of
>>> steps used by this driver. This doesn't take into account that other steps
>>> can be used by the touchscreen driver. Select the timeout value based on the
>>> steps used by both drivers
>>>
>>> Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
>> Looks fine to me but I'd like an Ack from someone more familiar with the device
>> if possible.
> Arun, do you feel entitled to Ack or can you suggest someone from TI
> who is?
>
Adding Sekhar Nori
>> Also, I'm assuming this is a fix we want to push out asap but that isn't
>> clear in your patch title. Perhaps something like:
>>
>> iio: ti_am335x_adc: Fix conversion timeout to allow for touch screen steps.
>> ?
> it's not as critical as it seems as in practice the timeout has the
> granularity of a jiffy. If you prefer I still can resend the patch
> with the subject you suggest
>
> best regards
>
next prev parent reply other threads:[~2013-09-23 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 21:17 [PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into account for conversion timeout Matthias Kaehlcke
2013-09-21 12:25 ` Jonathan Cameron
2013-09-22 17:51 ` Matthias Kaehlcke
2013-09-23 8:57 ` Arun Joseph [this message]
2013-09-23 9:36 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5240027C.9040804@ti.com \
--to=arunjoseph@ti.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.list@kaehlcke.net \
--cc=nsekhar@ti.com \
--cc=panto@antoniou-consulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.