From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO27h-0000hV-Qm for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:08:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO27b-0004CY-Rd for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:08:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO27b-0004CT-K1 for qemu-devel@nongnu.org; Mon, 23 Sep 2013 05:07:59 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8N97x0R026739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Sep 2013 05:07:59 -0400 Message-ID: <524004EC.4080005@redhat.com> Date: Mon, 23 Sep 2013 11:07:56 +0200 From: Max Reitz MIME-Version: 1.0 References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-17-git-send-email-kwolf@redhat.com> In-Reply-To: <1379678070-14346-17-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 16/17] blockdev: Don't disable COR automatically with blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On 2013-09-20 13:54, Kevin Wolf wrote: > If a read-only device is configured with copy-on-read=on, the old code > only prints a warning and automatically disables copy on read. Make it > a real error for blockdev-add. > > Signed-off-by: Kevin Wolf > --- > block.c | 9 +++++++-- > blockdev.c | 31 +++++++++++++++++++++++++++---- > 2 files changed, 34 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz