From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling Date: Mon, 23 Sep 2013 12:13:03 -0300 Message-ID: <52405A7F.1050801@freescale.com> References: <1379946998-23041-1-git-send-email-jbe@pengutronix.de> <1379946998-23041-2-git-send-email-jbe@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379946998-23041-2-git-send-email-jbe@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Juergen Beisert , linux-iio@vger.kernel.org Cc: devel@driverdev.osuosl.org, marex@denx.de, jic23@cam.ac.uk, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org On 09/23/2013 11:36 AM, Juergen Beisert wrote: > + lradc->clk = devm_clk_get(&pdev->dev, NULL); > + clk_prepare_enable(lradc->clk); clk_prepare_enable() may fail, so better check its return value. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [213.199.154.189] ([213.199.154.189]:57718 "EHLO db8outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752716Ab3IWPSF (ORCPT ); Mon, 23 Sep 2013 11:18:05 -0400 Message-ID: <52405A7F.1050801@freescale.com> Date: Mon, 23 Sep 2013 12:13:03 -0300 From: Fabio Estevam MIME-Version: 1.0 To: Juergen Beisert , CC: , , , , Subject: Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling References: <1379946998-23041-1-git-send-email-jbe@pengutronix.de> <1379946998-23041-2-git-send-email-jbe@pengutronix.de> In-Reply-To: <1379946998-23041-2-git-send-email-jbe@pengutronix.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/23/2013 11:36 AM, Juergen Beisert wrote: > + lradc->clk = devm_clk_get(&pdev->dev, NULL); > + clk_prepare_enable(lradc->clk); clk_prepare_enable() may fail, so better check its return value. From mboxrd@z Thu Jan 1 00:00:00 1970 From: fabio.estevam@freescale.com (Fabio Estevam) Date: Mon, 23 Sep 2013 12:13:03 -0300 Subject: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling In-Reply-To: <1379946998-23041-2-git-send-email-jbe@pengutronix.de> References: <1379946998-23041-1-git-send-email-jbe@pengutronix.de> <1379946998-23041-2-git-send-email-jbe@pengutronix.de> Message-ID: <52405A7F.1050801@freescale.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/23/2013 11:36 AM, Juergen Beisert wrote: > + lradc->clk = devm_clk_get(&pdev->dev, NULL); > + clk_prepare_enable(lradc->clk); clk_prepare_enable() may fail, so better check its return value.