From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO8KU-00089v-Nz for qemu-devel@nongnu.org; Mon, 23 Sep 2013 11:45:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO8KP-0003jn-Re for qemu-devel@nongnu.org; Mon, 23 Sep 2013 11:45:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO8KP-0003jc-G0 for qemu-devel@nongnu.org; Mon, 23 Sep 2013 11:45:37 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8NFjZF0030577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Sep 2013 11:45:36 -0400 Message-ID: <5240621E.5050001@redhat.com> Date: Mon, 23 Sep 2013 09:45:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1379678070-14346-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XiqLcQUG2XGt9Wx6kb0D2jp1GIGUfSPl3" Subject: Re: [Qemu-devel] [PATCH 05/17] blockdev: Separate ID generation from DriveInfo creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XiqLcQUG2XGt9Wx6kb0D2jp1GIGUfSPl3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/20/2013 05:54 AM, Kevin Wolf wrote: > blockdev-add shouldn't automatically generate IDs, but will keep most o= f > the DriveInfo creation code. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 32 +++++++++++++++++--------------- > include/qemu/option.h | 1 + > util/qemu-option.c | 6 ++++++ > 3 files changed, 24 insertions(+), 15 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XiqLcQUG2XGt9Wx6kb0D2jp1GIGUfSPl3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSQGIeAAoJEKeha0olJ0NqIOAH/0Z/ur2ZnITWVyOGd9mpzeDq fAfpz/LzBRcuoZnDko6SzSicdQzLsftMHExmY+BFbpGFopPlp2BnoPrIOorN8Gf1 B2/0L46qLw21N4b8Juu9Gw0kyFE48V3/kciQpRMxz+qF8DPG/rL+yIsDlB/BlKS2 gMG8LpJ3tBHGqfY6MWFrWjs5LyxaZ8A6KDMzOYAm92Bjm826Sz+yKAbMWue3BAYF yP+DZMoN04GQAZleLJyQ7M4x7MdR+CPgMipA6yXxiQAj+eo21tdAxw8xRkc7TmBU KUmWQ0qXyVcF8VAF4xXDpt5950vXgfdjGUZGGILoiHwbhpSmr39L+6wlkzLtMpQ= =nLLI -----END PGP SIGNATURE----- --XiqLcQUG2XGt9Wx6kb0D2jp1GIGUfSPl3--